Move multiple UI surfaces check to PageActionHandler.

Move multiple UI surfaces check to PageActionHandler.

(We don't need to check is_app because the features system doesn't provide browser/page actions to apps.)

BUG=159265
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203312

[Matt Perry, 2013-05-30 23:16:13]

lgtm

https://codereview.chromium.org/16092015/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/extension_action/page_action_handler.cc
(right):

https://codereview.chromium.org/16092015/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/extension_action/page_action_handler.cc:60: if
(extension->manifest()->HasKey(keys::kBrowserAction)) {
The asymmetry of this bothers me (as in, why not put this in the
BrowserActionHandler? What would we do if we had a third UI surface?)... but I
don't have a better solution.

[Yoyo Zhou, 2013-05-30 23:24:11]

https://codereview.chromium.org/16092015/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/extension_action/page_action_handler.cc
(right):

https://codereview.chromium.org/16092015/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/extension_action/page_action_handler.cc:60: if
(extension->manifest()->HasKey(keys::kBrowserAction)) {
On 2013/05/30 23:16:14, Matt Perry wrote:
> The asymmetry of this bothers me (as in, why not put this in the
> BrowserActionHandler? What would we do if we had a third UI surface?)... but I
> don't have a better solution. 

It's kind of a hack. A better or worse hack would be to put the check in
BrowserActionHandler too.

Less of a hack would be a post-Parse step where we introduce registered
constraints checkers. But this check is simple enough that it doesn't warrant
that kind of complexity.

[commit-bot: I haz the power, 2013-05-30 23:30:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/16092015/1

[commit-bot: I haz the power, 2013-05-31 02:19:08]

Change committed as 203312