Issue 16087005: Valgrind: Do not use the sandbox for layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16087005: Valgrind: Do not use the sandbox for layout tests. (Closed)

Created:
7 years, 6 months ago by Lei Zhang

Modified:
7 years, 6 months ago

Reviewers:
Timur Iskhodzhanov

CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Valgrind: Do not use the sandbox for layout tests. Recently layout tests changed to use content_shell instead of DRT. Content_shell attempts to use the sandbox if it can, and that made the Valgrind layout test bot unhappy. All other Valgrind bots disable the sandbox, and layout tests should too. TBR=timurrrr@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202732

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	tools/valgrind/valgrind_test.py	View		2 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/16087005/1

7 years, 6 months ago (2013-05-29 01:14:13 UTC) #2

Message was sent while issue was closed.

LGTM++

Thanks for the fix!

Expand Messages | Collapse Messages