Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Unified Diff: tools/valgrind/valgrind_test.py

Issue 16087005: Valgrind: Do not use the sandbox for layout tests. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/valgrind/valgrind_test.py
===================================================================
--- tools/valgrind/valgrind_test.py (revision 202727)
+++ tools/valgrind/valgrind_test.py (working copy)
@@ -390,6 +390,12 @@
# The Valgrind command is constructed.
+ # Valgrind doesn't play nice with the Chrome sandbox. Empty this env var
+ # set by runtest.py to disable the sandbox.
+ if os.environ.get("CHROME_DEVEL_SANDBOX", None):
+ logging.info("Removing CHROME_DEVEL_SANDBOX fron environment")
+ os.environ["CHROME_DEVEL_SANDBOX"] = ''
+
# Handle --indirect_webkit_layout separately.
if self._options.indirect_webkit_layout:
# Need to create the wrapper before modifying |proc|.
@@ -399,12 +405,6 @@
proc.append(wrapper)
return proc
- # Valgrind doesn't play nice with the Chrome sandbox. Empty this env var
- # set by runtest.py to disable the sandbox.
- if os.environ.get("CHROME_DEVEL_SANDBOX", None):
- logging.info("Removing CHROME_DEVEL_SANDBOX fron environment")
- os.environ["CHROME_DEVEL_SANDBOX"] = ''
-
if self._options.indirect:
wrapper = self.CreateBrowserWrapper(proc)
os.environ["BROWSER_WRAPPER"] = wrapper
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698