Issue 16058002: Better workaround for extension browser test problems on win debug bots

Issue 16058002: Better workaround for extension browser test problems on win debug bots (Closed)

Created:
7 years, 7 months ago by asargent_no_longer_on_chrome

Modified:
7 years, 6 months ago

Reviewers:
commit-bot: I haz the power, Matt Perry, Scott Hess - ex-Googler

CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+prer_chromium.org, tburkard+watch_chromium.org, Aaron Boodman, dominich+watch_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Better workaround for extension browser test problems on win debug bots Instead of trying to fake out gtest output and exiting, just return true in RunExtensionSubTest. TBR=shess@chromium.org,mpcomplete@chromium.org BUG=177163 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202339

Patch Set 1 #

Patch Set 2 : avoid leaving orphan temp directories #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -27 lines)			Patch
M	chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc	View		1 chunk	+8 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc	View	1	5 chunks	+23 lines, -19 lines	0 comments	Download
M	chrome/browser/extensions/extension_apitest.cc	View		1 chunk	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/prerender/prerender_browsertest.cc	View		1 chunk	+8 lines, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/webstore_private/theme.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

asargent_no_longer_on_chrome

TBR'ing this one to hopefully get the bots in better shape. We'll see if it ...

7 years, 7 months ago (2013-05-25 04:42:36 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/16058002/1005

7 years, 7 months ago (2013-05-25 04:42:49 UTC) #2

Scott Hess - ex-Googler

lgtm. Only thing that occurred to me was a log line for the other early ...

7 years, 7 months ago (2013-05-25 05:36:54 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=118448

7 years, 7 months ago (2013-05-25 07:08:48 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/16058002/1005

7 years, 7 months ago (2013-05-25 14:59:25 UTC) #5

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages