chrome/browser/extensions/extension_apitest.cc - Issue 16058002: Better workaround for extension browser test problems on win debug bots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_apitest.cc

Issue 16058002: Better workaround for extension browser test problems on win debug bots (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: avoid leaving orphan temp directories Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc ('k') | chrome/browser/prerender/prerender_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_apitest.cc

diff --git a/chrome/browser/extensions/extension_apitest.cc b/chrome/browser/extensions/extension_apitest.cc

index 09ed180f615d4721a1257135f1ab9594dbfb9c50..bfbe2d8e16cf6b1fda1b3bf75849d09c2c182826 100644

--- a/chrome/browser/extensions/extension_apitest.cc

+++ b/chrome/browser/extensions/extension_apitest.cc

@@ -166,11 +166,8 @@ bool ExtensionApiTest::RunExtensionSubtest(const char* extension_name,

DCHECK(!page_url.empty()) << "Argument page_url is required.";

// See http://crbug.com/177163 for details.

#if defined(OS_WIN) && !defined(NDEBUG)

- LOG(WARNING) << "Workaround for 177163, prematurely stopping test";

- // Following is necessary for sharding scripts to think the test passed.

- fprintf(stderr, "[ OK ] X (1000ms total)\r\n");

- fflush(stderr);

- ExitProcess(0);

+ LOG(WARNING) << "Workaround for 177163, prematurely returning";

+ return true;

#endif

return RunExtensionTestImpl(extension_name, page_url, flags);

}