Issue 16054005: [ASAN] Fix use-after-free.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16054005: [ASAN] Fix use-after-free. (Closed)

Created:
7 years, 6 months ago by groby-ooo-7-16

Modified:
7 years, 6 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, Raman Kakilate, benquan, ahutter, dbeam+watch-autofill_chromium.org, sail+watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[ASAN] Fix use-after-free. AutofillDialogController is self-destroying on ViewClosed. Thus, TestAutofillDialogController::runner_ is not available after ViewClosed, and RunMessageLoop must live on the TestFixture instead, since it is potentially run after the view has been closed (via controller->Hide) BUG=234008 TEST=none R=avi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202815

Patch Set 1 #

Patch Set 2 : Enable test. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -15 lines)			Patch
	M	chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa_browsertest.mm	View	1	3 chunks	+8 lines, -15 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/16054005/4001

7 years, 6 months ago (2013-05-29 03:04:59 UTC) #5

Message was sent while issue was closed.

Change committed as 202815

Expand Messages | Collapse Messages