[ASAN] Fix use-after-free.

chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa_browsertest.mm

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #import "chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h"
 
 #include "base/bind.h"
 #include "base/message_loop.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_controller_impl.h"
 #include "chrome/browser/ui/browser.h"
@@ skipping 27 matching lines @@
                                      base::Bind(MockCallback)),
         metric_logger_(metric_logger) ,
         runner_(runner) {
     DisableWallet();
   }
 
   virtual ~TestAutofillDialogController() {}
 
   virtual void ViewClosed() OVERRIDE {
     DCHECK(runner_);
+    runner_->Quit();
     AutofillDialogControllerImpl::ViewClosed();
-    runner_->Quit();
-  }
-
-  void RunMessageLoop() {
-    DCHECK(runner_);
-    runner_->Run();
   }
 
   AutofillDialogCocoa* GetView() {
     return static_cast<AutofillDialogCocoa*>(
         AutofillDialogControllerImpl::view());
   }
 
  private:
   // To specify our own metric logger.
   virtual const AutofillMetrics& GetMetricLogger() const OVERRIDE {
@@ skipping 24 matching lines @@
     controller_ = new TestAutofillDialogController(
         browser()->tab_strip_model()->GetActiveWebContents(),
         form_data,
         metric_logger_,
         runner_,
         DIALOG_TYPE_REQUEST_AUTOCOMPLETE);
   }
 
   TestAutofillDialogController* controller() { return controller_; }
 
+  void RunMessageLoop() {
+    DCHECK(runner_);
+    runner_->Run();
+  }
+
  private:
   // The controller owns itself.
   TestAutofillDialogController* controller_;
 
   // The following members must outlive the controller.
   AutofillMetrics metric_logger_;
   scoped_refptr<content::MessageLoopRunner> runner_;
 
   DISALLOW_COPY_AND_ASSIGN(AutofillDialogCocoaBrowserTest);
 };
 
-// The following test fails under ASAN due to a read-after-free.
-// http://crbug.com/234008
-#if defined(ADDRESS_SANITIZER)
-#define MAYBE_DisplayUI DISABLED_DisplayUI
-#else
-#define MAYBE_DisplayUI DisplayUI
-#endif
-IN_PROC_BROWSER_TEST_F(AutofillDialogCocoaBrowserTest, MAYBE_DisplayUI) {
+IN_PROC_BROWSER_TEST_F(AutofillDialogCocoaBrowserTest, DisplayUI) {
   controller()->Show();
   controller()->OnCancel();
   controller()->Hide();
 
-  controller()->RunMessageLoop();
+  RunMessageLoop();
 }
 
 }  // namespace
 
 }  // namespace autofill