Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 16035014: Don't ignore the actual input representation in UnaryMathOperations (Closed)

Created:
7 years, 6 months ago by Toon Verwaest
Modified:
7 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Don't ignore the actual input representation in UnaryMathOperations R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14997

Patch Set 1 #

Total comments: 2

Patch Set 2 : Don't use unset observed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M src/hydrogen-instructions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Toon Verwaest
PTAL
7 years, 6 months ago (2013-06-07 08:26:13 UTC) #1
Jakob Kummerow
https://chromiumcodereview.appspot.com/16035014/diff/1/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://chromiumcodereview.appspot.com/16035014/diff/1/src/hydrogen-instructions.cc#newcode3075 src/hydrogen-instructions.cc:3075: rep = rep.generalize(observed_input_representation(1)); HUnaryMathOperation doesn't have observed input representations ...
7 years, 6 months ago (2013-06-07 08:44:45 UTC) #2
Toon Verwaest
Addressed comment, ptal https://chromiumcodereview.appspot.com/16035014/diff/1/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://chromiumcodereview.appspot.com/16035014/diff/1/src/hydrogen-instructions.cc#newcode3075 src/hydrogen-instructions.cc:3075: rep = rep.generalize(observed_input_representation(1)); On 2013/06/07 08:44:45, ...
7 years, 6 months ago (2013-06-07 09:09:52 UTC) #3
Jakob Kummerow
lgtm
7 years, 6 months ago (2013-06-07 09:10:45 UTC) #4
Toon Verwaest
7 years, 6 months ago (2013-06-07 09:11:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r14997 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698