Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2391)

Side by Side Diff: src/hydrogen-instructions.h

Issue 16035014: Don't ignore the actual input representation in UnaryMathOperations (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Don't use unset observed Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen-instructions.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2627 matching lines...) Expand 10 before | Expand all | Expand 10 after
2638 case kMathAbs: 2638 case kMathAbs:
2639 return representation(); 2639 return representation();
2640 default: 2640 default:
2641 UNREACHABLE(); 2641 UNREACHABLE();
2642 return Representation::None(); 2642 return Representation::None();
2643 } 2643 }
2644 } 2644 }
2645 } 2645 }
2646 2646
2647 virtual HValue* Canonicalize(); 2647 virtual HValue* Canonicalize();
2648 virtual Representation RepresentationFromInputs();
2648 2649
2649 BuiltinFunctionId op() const { return op_; } 2650 BuiltinFunctionId op() const { return op_; }
2650 const char* OpName() const; 2651 const char* OpName() const;
2651 2652
2652 DECLARE_CONCRETE_INSTRUCTION(UnaryMathOperation) 2653 DECLARE_CONCRETE_INSTRUCTION(UnaryMathOperation)
2653 2654
2654 protected: 2655 protected:
2655 virtual bool DataEquals(HValue* other) { 2656 virtual bool DataEquals(HValue* other) {
2656 HUnaryMathOperation* b = HUnaryMathOperation::cast(other); 2657 HUnaryMathOperation* b = HUnaryMathOperation::cast(other);
2657 return op_ == b->op(); 2658 return op_ == b->op();
(...skipping 3900 matching lines...) Expand 10 before | Expand all | Expand 10 after
6558 virtual bool IsDeletable() const { return true; } 6559 virtual bool IsDeletable() const { return true; }
6559 }; 6560 };
6560 6561
6561 6562
6562 #undef DECLARE_INSTRUCTION 6563 #undef DECLARE_INSTRUCTION
6563 #undef DECLARE_CONCRETE_INSTRUCTION 6564 #undef DECLARE_CONCRETE_INSTRUCTION
6564 6565
6565 } } // namespace v8::internal 6566 } } // namespace v8::internal
6566 6567
6567 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 6568 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen-instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698