Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 16035002: Fix degenerate and near-degenerate quadratic hairlines on the gpu (Closed)

Created:
7 years, 7 months ago by bsalomon
Modified:
7 years, 7 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix degenerate and near-degenerate hairlines on the gpu Committed: http://code.google.com/p/skia/source/detail?r=9279

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : revert whitespace #

Total comments: 5

Patch Set 4 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -30 lines) Patch
A gm/hairlines.cpp View 1 2 3 1 chunk +143 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 2 3 4 chunks +41 lines, -30 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bsalomon
7 years, 7 months ago (2013-05-24 18:13:21 UTC) #1
robertphillips
lgtm + nits https://codereview.chromium.org/16035002/diff/4001/gm/hairlines.cpp File gm/hairlines.cpp (right): https://codereview.chromium.org/16035002/diff/4001/gm/hairlines.cpp#newcode20 gm/hairlines.cpp:20: is this an override too? https://codereview.chromium.org/16035002/diff/4001/gm/hairlines.cpp#newcode129 ...
7 years, 7 months ago (2013-05-24 18:23:14 UTC) #2
bsalomon
https://codereview.chromium.org/16035002/diff/4001/gm/hairlines.cpp File gm/hairlines.cpp (right): https://codereview.chromium.org/16035002/diff/4001/gm/hairlines.cpp#newcode20 gm/hairlines.cpp:20: On 2013/05/24 18:23:14, robertphillips wrote: > is this an ...
7 years, 7 months ago (2013-05-24 18:30:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/16035002/10001
7 years, 7 months ago (2013-05-24 18:31:09 UTC) #4
commit-bot: I haz the power
7 years, 7 months ago (2013-05-24 18:51:57 UTC) #5
Message was sent while issue was closed.
Change committed as 9279

Powered by Google App Engine
This is Rietveld 408576698