Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 16003003: Fix my_reviews.py to not print negative numbers. (Closed)

Created:
7 years, 6 months ago by M-A Ruel
Modified:
7 years, 6 months ago
Reviewers:
iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Visibility:
Public.

Description

Fix my_reviews.py to not print negative numbers. .search() may return results in unexpected order. Manually sort the entries otherwise first_day and last_day could be inversed, leading to negative number of days. R=iannucci@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=203792

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M my_reviews.py View 2 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
7 years, 6 months ago (2013-05-30 19:26:13 UTC) #1
iannucci
lgtm
7 years, 6 months ago (2013-06-03 23:35:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/16003003/1
7 years, 6 months ago (2013-06-03 23:38:36 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-03 23:40:11 UTC) #4
Message was sent while issue was closed.
Change committed as 203792

Powered by Google App Engine
This is Rietveld 408576698