Fix my_reviews.py to not print negative numbers.

my_reviews.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Get rietveld stats about the review you done, or forgot to do.
 
 Example:
   - my_reviews.py -r me@chromium.org -Q  for stats for last quarter.
 """
@@ skipping 92 matching lines @@
     return self.total * 1. / self.days
 
   @property
   def review_done_per_day(self):
     if not self.days:
       return 0
     return self.actually_reviewed * 1. / self.days
 
   def finalize(self, first_day, last_day):
     if self.actually_reviewed:
+      assert self.actually_reviewed > 0
       self.percent_lgtm = (self.lgtms * 100. / self.actually_reviewed)
       self.percent_drive_by = (self.drive_by * 100. / self.actually_reviewed)
       self.percent_not_requested = (
           self.not_requested * 100. / self.actually_reviewed)
+    assert bool(first_day) == bool(last_day)
     if first_day and last_day:
+      assert first_day < last_day
       self.days = (to_datetime(last_day) - to_datetime(first_day)).days + 1
+      assert self.days > 0
 
 
 def _process_issue_lgtms(issue, reviewer, stats):
   """Calculates LGTMs stats."""
   stats.actually_reviewed += 1
   reviewer_lgtms = len([
     msg for msg in issue['messages']
     if msg['approval'] and msg['sender'] == reviewer])
   if reviewer_lgtms > 1:
     stats.multiple_lgtms += 1
@@ skipping 81 matching lines @@
       ', '.join(sorted(issue['reviewers'])))
 
 
 def print_reviews(reviewer, created_after, created_before, instance_url):
   """Prints issues |reviewer| received and potentially reviewed."""
   remote = rietveld.Rietveld(instance_url, None, None)
 
   # The stats we gather. Feel free to send me a CL to get more stats.
   stats = Stats()
 
-  last_issue = None
-  first_day = None
-  last_day = None
-
   # Column sizes need to match print_issue() output.
   print >> sys.stderr, (
       'Issue   Creation   Did         Latency Owner           Reviewers')
 
   # See def search() in rietveld.py to see all the filters you can use.
+  issues = []
   for issue in remote.search(
       reviewer=reviewer,
       created_after=created_after,
       created_before=created_before,
       with_messages=True):
-    last_issue = issue
-    if not first_day:
-      first_day = issue['created'][:10]
+    issues.append(issue)
     print_issue(issue, username(reviewer), stats)
-  if last_issue:
-    last_day = last_issue['created'][:10]
+
+  issues.sort(key=lambda x: x['created'])
+  first_day = None
+  last_day = None
+  if issues:
+    first_day = issues[0]['created'][:10]
+    last_day = issues[-1]['created'][:10]
   stats.finalize(first_day, last_day)
 
   print >> sys.stderr, (
       '%s reviewed %d issues out of %d (%1.1f%%). %d were self-review.' %
       (reviewer, stats.actually_reviewed, stats.total, stats.percent_done,
         stats.self_review))
   print >> sys.stderr, (
       '%4.1f review request/day during %3d days   (%4.1f r/d done).' % (
       stats.review_per_day, stats.days, stats.review_done_per_day))
   print >> sys.stderr, (
@@ skipping 98 matching lines @@
     print_reviews(
         options.reviewer,
         options.begin,
         options.end,
         options.instance_url)
   return 0
 
 
 if __name__ == '__main__':
   sys.exit(main())