Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1944)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15995038: Use a direct include of utf_string_conversions.h in google_apis/, gpu/, ipc/, media/, ppapi/, print… (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, tzik+watch_chromium.org, amit, dcheng, kinuko+watch, stevenjb+watch_chromium.org, sergeyu+watch_chromium.org, dcaiafa+watch_chromium.org, jam, apatrick_chromium, darin-cc_chromium.org, tim (not reviewing), michaeln, wez+watch_chromium.org, Raghu Simha, sanjeevr, feature-media-reviews_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, haitaol1, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, akalin, sail+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, Paweł Hajdan Jr., alexeypa+watch_chromium.org
Visibility:
Public.

Description

Use a direct include of utf_string_conversions.h in google_apis/, gpu/, ipc/, media/, ppapi/, printing/, remoting/, rlz/, skia/, sql/, sync/, third_party/, tools/, webkit/, win8/. BUG=none TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204967

Patch Set 1 #

Patch Set 2 : better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -158 lines) Patch
M google_apis/gaia/oauth2_mint_token_flow.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/oauth2_mint_token_flow_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_dx_diagnostics_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/demos/framework/window_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_message_utils.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_device_listener_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_device_listener_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_low_latency_input_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_low_latency_output_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/core_audio_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/device_enumeration_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/file_data_source_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/test/ffmpeg_tests/ffmpeg_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/media_bench/media_bench.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/browser_font_resource_trusted.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/pdf_resource_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/backend/print_backend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/backend/print_backend_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/backend/win_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/print_settings_initializer.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/print_settings_initializer_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/printed_document.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_context_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/base/breakpad_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/base/breakpad_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/clipboard_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/continue_window_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/continue_window_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/daemon_process_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/desktop_session_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/disconnect_window_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/disconnect_window_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/disconnect_window_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/host_event_logger_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/host_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/ipc_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/plugin/host_script_object.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/policy_hack/policy_watcher_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/sas_injector_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/setup/daemon_controller_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/setup/daemon_installer_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/setup/win/auth_code_getter.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/setup/win/start_host_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/ui_strings.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/verify_config_window_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/elevated_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/win/host_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/launch_process_with_token.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/message_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/rdp_client_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/security_descriptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/unprivileged_process_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/wts_session_process_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/wts_terminal_monitor.cc View 1 chunk +1 line, -1 line 0 comments Download
M rlz/lib/financial_ping.cc View 1 chunk +1 line, -1 line 0 comments Download
M rlz/lib/financial_ping_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M rlz/lib/machine_id_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M rlz/lib/string_utils_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M rlz/mac/lib/machine_id_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M rlz/win/lib/registry_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M rlz/win/lib/rlz_value_store_registry.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M skia/ext/image_operations_bench.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/vector_canvas_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sql/connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M sql/statement.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/base_node.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/sync_manager_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/write_node.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/util/time.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/leveldatabase/env_chromium.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/google/zip_internal.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/google/zip_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/google/zip_reader_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/imagediff/image_diff.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/memory_watcher/memory_watcher.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/base/file_path_string_conversions.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/base/origin_url_conversions.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/appcache/appcache_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/appcache/manifest_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/appcache/view_appcache_internals_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/blob/view_blob_internals_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/chromeos/fileapi/cros_mount_point_provider.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/chromeos/fileapi/remote_file_system_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/database/database_quota_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/database/database_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/database/database_tracker_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/database/database_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/database/database_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/database/databases_table.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/database/databases_table_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/dom_storage/dom_storage_area.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/dom_storage/dom_storage_area_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/dom_storage/dom_storage_context_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/dom_storage/dom_storage_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/dom_storage/session_storage_database.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/dom_storage/session_storage_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_dir_url_request_job.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_dir_url_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_url_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/local_file_system_operation.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/local_file_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/obfuscated_file_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/blob/blob_data.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/database/database_connections_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/dom_storage/dom_storage_map_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/fileapi/file_system_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/webdropdata.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/webpreferences.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/ftp_directory_listing_response_delegate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/glue_serialize_deprecated.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/simple_webmimeregistry_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webclipboard_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webkit_glue.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webkitplatformsupport_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_instance.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/plugin_lib_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_list_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_list_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_list_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_stream.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/plugin_utils_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/test/plugin_geturl_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/webplugin_ime_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/webplugin_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/event_conversion.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/host_globals.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_file_ref_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_graphics_3d_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/webplugininfo.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/renderer/cpp_bound_class.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/renderer/cpp_variant.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/renderer/dom_storage/dom_storage_cached_area_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/renderer/fileapi/webfilewriter_base_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/renderer/webpreferences_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/mock_webclipboard_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/platform_support_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/simple_database_system.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/simple_file_system.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/simple_socket_stream_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/webkit_support.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M win8/delegate_execute/chrome_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/delegate_execute/command_execute_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/delegate_execute/delegate_execute_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/metro_driver/secondary_tile.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/metro_driver/toast_notification_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Avi (use Gerrit)
7 years, 6 months ago (2013-06-07 16:06:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/15995038/2018
7 years, 6 months ago (2013-06-07 16:28:53 UTC) #2
commit-bot: I haz the power
7 years, 6 months ago (2013-06-07 22:40:50 UTC) #3
Message was sent while issue was closed. 
Change committed as 204967

Powered by Google App Engine
This is Rietveld 408576698