Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Side by Side Diff: webkit/plugins/npapi/plugin_utils_unittest.cc

Issue 15995038: Use a direct include of utf_string_conversions.h in google_apis/, gpu/, ipc/, media/, ppapi/, print… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: better Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/plugins/npapi/plugin_stream.cc ('k') | webkit/plugins/npapi/test/plugin_geturl_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "webkit/plugins/npapi/plugin_utils.h" 5 #include "webkit/plugins/npapi/plugin_utils.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
11 #include "base/utf_string_conversions.h" 11 #include "base/strings/utf_string_conversions.h"
12 #include "base/version.h" 12 #include "base/version.h"
13 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
14 14
15 namespace webkit { 15 namespace webkit {
16 namespace npapi { 16 namespace npapi {
17 17
18 TEST(PluginUtilsTest, VersionExtraction) { 18 TEST(PluginUtilsTest, VersionExtraction) {
19 // Some real-world plugin versions (spaces, commata, parentheses, 'r', oh my) 19 // Some real-world plugin versions (spaces, commata, parentheses, 'r', oh my)
20 const char* versions[][2] = { 20 const char* versions[][2] = {
21 { "7.6.6 (1671)", "7.6.6.1671" }, // Quicktime 21 { "7.6.6 (1671)", "7.6.6.1671" }, // Quicktime
(...skipping 13 matching lines...) Expand all
35 Version version; 35 Version version;
36 CreateVersionFromString(ASCIIToUTF16(versions[i][0]), &version); 36 CreateVersionFromString(ASCIIToUTF16(versions[i][0]), &version);
37 37
38 ASSERT_TRUE(version.IsValid()); 38 ASSERT_TRUE(version.IsValid());
39 EXPECT_EQ(versions[i][1], version.GetString()); 39 EXPECT_EQ(versions[i][1], version.GetString());
40 } 40 }
41 } 41 }
42 42
43 } // namespace npapi 43 } // namespace npapi
44 } // namespace webkit 44 } // namespace webkit
OLDNEW
« no previous file with comments | « webkit/plugins/npapi/plugin_stream.cc ('k') | webkit/plugins/npapi/test/plugin_geturl_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698