Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: chrome/browser/translate/translate_browser_metrics.cc

Issue 15987004: Translate: Filter and record languages whose names Chrome doesn't show (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Modified the test Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_browser_metrics.cc
diff --git a/chrome/browser/translate/translate_manager_metrics.cc b/chrome/browser/translate/translate_browser_metrics.cc
similarity index 71%
rename from chrome/browser/translate/translate_manager_metrics.cc
rename to chrome/browser/translate/translate_browser_metrics.cc
index 4b88bff25e5d2f528ec4bd074090fb47243e763a..0a8e582549955a6c1a520720ce898240dcf3c499 100644
--- a/chrome/browser/translate/translate_manager_metrics.cc
+++ b/chrome/browser/translate/translate_browser_metrics.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/translate/translate_manager_metrics.h"
+#include "chrome/browser/translate/translate_browser_metrics.h"
#include <string>
@@ -19,38 +19,38 @@ const char kTranslateInitiationStatus[] =
"Translate.InitiationStatus";
const char kTranslateReportLanguageDetectionError[] =
"Translate.ReportLanguageDetectionError";
-const char kTranslateServerReportedUnsupportedLanguage[] =
- "Translate.ServerReportedUnsupportedLanguage";
-const char kTranslateUnsupportedLanguageAtInitiation[] =
- "Translate.UnsupportedLanguageAtInitiation";
const char kTranslateLocalesOnDisabledByPrefs[] =
"Translate.LocalesOnDisabledByPrefs";
+const char kTranslateUndisplayableLanguage[] =
+ "Translate.UndisplayableLanguage";
+const char kTranslateUnsupportedLanguageAtInitiation[] =
+ "Translate.UnsupportedLanguageAtInitiation";
struct MetricsEntry {
- TranslateManagerMetrics::MetricsNameIndex index;
+ TranslateBrowserMetrics::MetricsNameIndex index;
const char* const name;
};
// This entry table should be updated when new UMA items are added.
const MetricsEntry kMetricsEntries[] = {
- { TranslateManagerMetrics::UMA_INITIATION_STATUS,
+ { TranslateBrowserMetrics::UMA_INITIATION_STATUS,
kTranslateInitiationStatus },
- { TranslateManagerMetrics::UMA_LANGUAGE_DETECTION_ERROR,
+ { TranslateBrowserMetrics::UMA_LANGUAGE_DETECTION_ERROR,
kTranslateReportLanguageDetectionError },
- { TranslateManagerMetrics::UMA_SERVER_REPORTED_UNSUPPORTED_LANGUAGE,
- kTranslateServerReportedUnsupportedLanguage },
- { TranslateManagerMetrics::UMA_UNSUPPORTED_LANGUAGE_AT_INITIATION,
- kTranslateUnsupportedLanguageAtInitiation },
- { TranslateManagerMetrics::UMA_LOCALES_ON_DISABLED_BY_PREFS,
+ { TranslateBrowserMetrics::UMA_LOCALES_ON_DISABLED_BY_PREFS,
kTranslateLocalesOnDisabledByPrefs },
+ { TranslateBrowserMetrics::UMA_UNDISPLAYABLE_LANGUAGE,
+ kTranslateUndisplayableLanguage },
+ { TranslateBrowserMetrics::UMA_UNSUPPORTED_LANGUAGE_AT_INITIATION,
+ kTranslateUnsupportedLanguageAtInitiation },
};
-COMPILE_ASSERT(arraysize(kMetricsEntries) == TranslateManagerMetrics::UMA_MAX,
+COMPILE_ASSERT(arraysize(kMetricsEntries) == TranslateBrowserMetrics::UMA_MAX,
arraysize_of_kMetricsEntries_should_be_UMA_MAX);
} // namespace
-namespace TranslateManagerMetrics {
+namespace TranslateBrowserMetrics {
void ReportInitiationStatus(InitiationStatusType type) {
UMA_HISTOGRAM_ENUMERATION(kTranslateInitiationStatus,
@@ -62,8 +62,15 @@ void ReportLanguageDetectionError() {
UMA_HISTOGRAM_BOOLEAN(kTranslateReportLanguageDetectionError, true);
}
-void ReportUnsupportedLanguage() {
- UMA_HISTOGRAM_BOOLEAN(kTranslateServerReportedUnsupportedLanguage, true);
+void ReportLocalesOnDisabledByPrefs(const std::string& locale) {
+ UMA_HISTOGRAM_SPARSE_SLOWLY(kTranslateLocalesOnDisabledByPrefs,
+ LanguageUsageMetrics::ToLanguageCode(locale));
+}
+
+void ReportUndisplayableLanguage(const std::string& language) {
+ int language_code = LanguageUsageMetrics::ToLanguageCode(language);
+ UMA_HISTOGRAM_SPARSE_SLOWLY(kTranslateUndisplayableLanguage,
+ language_code);
}
void ReportUnsupportedLanguageAtInitiation(const std::string& language) {
@@ -72,11 +79,6 @@ void ReportUnsupportedLanguageAtInitiation(const std::string& language) {
language_code);
}
-void ReportLocalesOnDisabledByPrefs(const std::string& locale) {
- UMA_HISTOGRAM_SPARSE_SLOWLY(kTranslateLocalesOnDisabledByPrefs,
- LanguageUsageMetrics::ToLanguageCode(locale));
-}
-
const char* GetMetricsName(MetricsNameIndex index) {
for (size_t i = 0; i < arraysize(kMetricsEntries); ++i) {
if (kMetricsEntries[i].index == index)
@@ -86,4 +88,4 @@ const char* GetMetricsName(MetricsNameIndex index) {
return NULL;
}
-} // namespace TranslateManagerMetrics
+} // namespace TranslateBrowserMetrics
« no previous file with comments | « chrome/browser/translate/translate_browser_metrics.h ('k') | chrome/browser/translate/translate_browser_metrics_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698