Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: chrome/browser/translate/translate_browser_metrics.cc

Issue 15987004: Translate: Filter and record languages whose names Chrome doesn't show (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Modified the test Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/translate/translate_manager_metrics.h" 5 #include "chrome/browser/translate/translate_browser_metrics.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/metrics/histogram.h" 10 #include "base/metrics/histogram.h"
11 #include "base/metrics/sparse_histogram.h" 11 #include "base/metrics/sparse_histogram.h"
12 #include "chrome/browser/language_usage_metrics.h" 12 #include "chrome/browser/language_usage_metrics.h"
13 13
14 namespace { 14 namespace {
15 15
16 // Constant string values to indicate UMA names. All entries should have 16 // Constant string values to indicate UMA names. All entries should have
17 // a corresponding index in MetricsNameIndex and an entry in |kMetricsEntries|. 17 // a corresponding index in MetricsNameIndex and an entry in |kMetricsEntries|.
18 const char kTranslateInitiationStatus[] = 18 const char kTranslateInitiationStatus[] =
19 "Translate.InitiationStatus"; 19 "Translate.InitiationStatus";
20 const char kTranslateReportLanguageDetectionError[] = 20 const char kTranslateReportLanguageDetectionError[] =
21 "Translate.ReportLanguageDetectionError"; 21 "Translate.ReportLanguageDetectionError";
22 const char kTranslateServerReportedUnsupportedLanguage[] = 22 const char kTranslateLocalesOnDisabledByPrefs[] =
23 "Translate.ServerReportedUnsupportedLanguage"; 23 "Translate.LocalesOnDisabledByPrefs";
24 const char kTranslateUndisplayableLanguage[] =
25 "Translate.UndisplayableLanguage";
24 const char kTranslateUnsupportedLanguageAtInitiation[] = 26 const char kTranslateUnsupportedLanguageAtInitiation[] =
25 "Translate.UnsupportedLanguageAtInitiation"; 27 "Translate.UnsupportedLanguageAtInitiation";
26 const char kTranslateLocalesOnDisabledByPrefs[] =
27 "Translate.LocalesOnDisabledByPrefs";
28 28
29 struct MetricsEntry { 29 struct MetricsEntry {
30 TranslateManagerMetrics::MetricsNameIndex index; 30 TranslateBrowserMetrics::MetricsNameIndex index;
31 const char* const name; 31 const char* const name;
32 }; 32 };
33 33
34 // This entry table should be updated when new UMA items are added. 34 // This entry table should be updated when new UMA items are added.
35 const MetricsEntry kMetricsEntries[] = { 35 const MetricsEntry kMetricsEntries[] = {
36 { TranslateManagerMetrics::UMA_INITIATION_STATUS, 36 { TranslateBrowserMetrics::UMA_INITIATION_STATUS,
37 kTranslateInitiationStatus }, 37 kTranslateInitiationStatus },
38 { TranslateManagerMetrics::UMA_LANGUAGE_DETECTION_ERROR, 38 { TranslateBrowserMetrics::UMA_LANGUAGE_DETECTION_ERROR,
39 kTranslateReportLanguageDetectionError }, 39 kTranslateReportLanguageDetectionError },
40 { TranslateManagerMetrics::UMA_SERVER_REPORTED_UNSUPPORTED_LANGUAGE, 40 { TranslateBrowserMetrics::UMA_LOCALES_ON_DISABLED_BY_PREFS,
41 kTranslateServerReportedUnsupportedLanguage }, 41 kTranslateLocalesOnDisabledByPrefs },
42 { TranslateManagerMetrics::UMA_UNSUPPORTED_LANGUAGE_AT_INITIATION, 42 { TranslateBrowserMetrics::UMA_UNDISPLAYABLE_LANGUAGE,
43 kTranslateUndisplayableLanguage },
44 { TranslateBrowserMetrics::UMA_UNSUPPORTED_LANGUAGE_AT_INITIATION,
43 kTranslateUnsupportedLanguageAtInitiation }, 45 kTranslateUnsupportedLanguageAtInitiation },
44 { TranslateManagerMetrics::UMA_LOCALES_ON_DISABLED_BY_PREFS,
45 kTranslateLocalesOnDisabledByPrefs },
46 }; 46 };
47 47
48 COMPILE_ASSERT(arraysize(kMetricsEntries) == TranslateManagerMetrics::UMA_MAX, 48 COMPILE_ASSERT(arraysize(kMetricsEntries) == TranslateBrowserMetrics::UMA_MAX,
49 arraysize_of_kMetricsEntries_should_be_UMA_MAX); 49 arraysize_of_kMetricsEntries_should_be_UMA_MAX);
50 50
51 } // namespace 51 } // namespace
52 52
53 namespace TranslateManagerMetrics { 53 namespace TranslateBrowserMetrics {
54 54
55 void ReportInitiationStatus(InitiationStatusType type) { 55 void ReportInitiationStatus(InitiationStatusType type) {
56 UMA_HISTOGRAM_ENUMERATION(kTranslateInitiationStatus, 56 UMA_HISTOGRAM_ENUMERATION(kTranslateInitiationStatus,
57 type, 57 type,
58 INITIATION_STATUS_MAX); 58 INITIATION_STATUS_MAX);
59 } 59 }
60 60
61 void ReportLanguageDetectionError() { 61 void ReportLanguageDetectionError() {
62 UMA_HISTOGRAM_BOOLEAN(kTranslateReportLanguageDetectionError, true); 62 UMA_HISTOGRAM_BOOLEAN(kTranslateReportLanguageDetectionError, true);
63 } 63 }
64 64
65 void ReportUnsupportedLanguage() { 65 void ReportLocalesOnDisabledByPrefs(const std::string& locale) {
66 UMA_HISTOGRAM_BOOLEAN(kTranslateServerReportedUnsupportedLanguage, true); 66 UMA_HISTOGRAM_SPARSE_SLOWLY(kTranslateLocalesOnDisabledByPrefs,
67 LanguageUsageMetrics::ToLanguageCode(locale));
68 }
69
70 void ReportUndisplayableLanguage(const std::string& language) {
71 int language_code = LanguageUsageMetrics::ToLanguageCode(language);
72 UMA_HISTOGRAM_SPARSE_SLOWLY(kTranslateUndisplayableLanguage,
73 language_code);
67 } 74 }
68 75
69 void ReportUnsupportedLanguageAtInitiation(const std::string& language) { 76 void ReportUnsupportedLanguageAtInitiation(const std::string& language) {
70 int language_code = LanguageUsageMetrics::ToLanguageCode(language); 77 int language_code = LanguageUsageMetrics::ToLanguageCode(language);
71 UMA_HISTOGRAM_SPARSE_SLOWLY(kTranslateUnsupportedLanguageAtInitiation, 78 UMA_HISTOGRAM_SPARSE_SLOWLY(kTranslateUnsupportedLanguageAtInitiation,
72 language_code); 79 language_code);
73 } 80 }
74 81
75 void ReportLocalesOnDisabledByPrefs(const std::string& locale) {
76 UMA_HISTOGRAM_SPARSE_SLOWLY(kTranslateLocalesOnDisabledByPrefs,
77 LanguageUsageMetrics::ToLanguageCode(locale));
78 }
79
80 const char* GetMetricsName(MetricsNameIndex index) { 82 const char* GetMetricsName(MetricsNameIndex index) {
81 for (size_t i = 0; i < arraysize(kMetricsEntries); ++i) { 83 for (size_t i = 0; i < arraysize(kMetricsEntries); ++i) {
82 if (kMetricsEntries[i].index == index) 84 if (kMetricsEntries[i].index == index)
83 return kMetricsEntries[i].name; 85 return kMetricsEntries[i].name;
84 } 86 }
85 NOTREACHED(); 87 NOTREACHED();
86 return NULL; 88 return NULL;
87 } 89 }
88 90
89 } // namespace TranslateManagerMetrics 91 } // namespace TranslateBrowserMetrics
OLDNEW
« no previous file with comments | « chrome/browser/translate/translate_browser_metrics.h ('k') | chrome/browser/translate/translate_browser_metrics_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698