Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15981010: Use a direct include of strings headers in chrome/common/, part 1. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, markusheintz_, jshin+watch_chromium.org, sail+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Use a direct include of strings headers in chrome/common/, part 1. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205377

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -76 lines) Patch
M chrome/common/automation_id.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/badge_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/child_process_logging.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/child_process_logging_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/child_process_logging_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/child_process_logging_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/child_process_logging_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_paths.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_utility_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_version_info_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_version_info_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/cloud_print/cloud_print_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/cloud_print/cloud_print_helpers_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/content_settings_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/content_settings_pattern.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/content_settings_pattern_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/custom_handlers/protocol_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/commands/commands_manifest_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_action/action_info.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_api_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/i18n/default_locale_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/input_ime/input_components_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/omnibox/omnibox_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/page_launcher/page_launcher_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/system_indicator/system_indicator_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/command.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/command.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/command_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/csp_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/csp_validator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_constants.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_file_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_l10n_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension_localization_peer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/feature_switch.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/features/feature.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/features/simple_feature.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/incognito_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handler_helpers.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/app_isolation_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/content_scripts_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/kiosk_enabled_info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/nacl_modules_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/offline_enabled_info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/sandboxed_page_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/shared_module_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_url_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/message_bundle.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/message_bundle_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/mime_types_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/permissions/bluetooth_device_permission.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/permissions/media_galleries_permission.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/permissions/media_galleries_permission_data.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/15981010/1
7 years, 6 months ago (2013-06-10 19:09:23 UTC) #1
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=160678
7 years, 6 months ago (2013-06-10 23:23:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/15981010/1
7 years, 6 months ago (2013-06-10 23:25:56 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 01:41:50 UTC) #4
Message was sent while issue was closed. 
Change committed as 205377

Powered by Google App Engine
This is Rietveld 408576698