chrome/common/extensions/extension_file_util_unittest.cc - Issue 15981010: Use a direct include of strings headers in chrome/common/, part 1.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/extension_file_util_unittest.cc

Issue 15981010: Use a direct include of strings headers in chrome/common/, part 1. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/common/extensions/extension_file_util.cc ('k') | chrome/common/extensions/extension_l10n_util.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/common/extensions/extension_file_util.h"	5 #include "chrome/common/extensions/extension_file_util.h"

6	6

7 #include "base/file_util.h"	7 #include "base/file_util.h"

8 #include "base/files/scoped_temp_dir.h"	8 #include "base/files/scoped_temp_dir.h"

9 #include "base/json/json_string_value_serializer.h"	9 #include "base/json/json_string_value_serializer.h"

10 #include "base/path_service.h"	10 #include "base/path_service.h"

11 #include "base/stringprintf.h"	11 #include "base/strings/stringprintf.h"

12 #include "base/strings/utf_string_conversions.h"	12 #include "base/strings/utf_string_conversions.h"

13 #include "chrome/common/chrome_paths.h"	13 #include "chrome/common/chrome_paths.h"

14 #include "chrome/common/extensions/extension.h"	14 #include "chrome/common/extensions/extension.h"

15 #include "chrome/common/extensions/extension_manifest_constants.h"	15 #include "chrome/common/extensions/extension_manifest_constants.h"

16 #include "chrome/common/extensions/manifest.h"	16 #include "chrome/common/extensions/manifest.h"

17 #include "extensions/common/constants.h"	17 #include "extensions/common/constants.h"

18 #include "grit/generated_resources.h"	18 #include "grit/generated_resources.h"

19 #include "testing/gmock/include/gmock/gmock.h"	19 #include "testing/gmock/include/gmock/gmock.h"

20 #include "testing/gtest/include/gtest/gtest.h"	20 #include "testing/gtest/include/gtest/gtest.h"

21 #include "ui/base/l10n/l10n_util.h"	21 #include "ui/base/l10n/l10n_util.h"

(...skipping 545 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
567 scoped_refptr<Extension> extension3(extension_file_util::LoadExtension(	567 scoped_refptr<Extension> extension3(extension_file_util::LoadExtension(

568 ext_dir, Manifest::UNPACKED, Extension::NO_FLAGS, &error));	568 ext_dir, Manifest::UNPACKED, Extension::NO_FLAGS, &error));

569 EXPECT_TRUE(extension3.get() == NULL);	569 EXPECT_TRUE(extension3.get() == NULL);

570 EXPECT_STREQ("Could not load icon 'icon.png' for page action.",	570 EXPECT_STREQ("Could not load icon 'icon.png' for page action.",

571 error.c_str());	571 error.c_str());

572 }	572 }

573	573

574 // TODO(aa): More tests as motivation allows. Maybe steal some from	574 // TODO(aa): More tests as motivation allows. Maybe steal some from

575 // ExtensionService? Many of them could probably be tested here without the	575 // ExtensionService? Many of them could probably be tested here without the

576 // MessageLoop shenanigans.	576 // MessageLoop shenanigans.

OLD	NEW