Android: renames pylib.constants.CHROME_DIR to DIR_SOURCE_ROOT.

Android: renames pylib.constants.CHROME_DIR to DIR_SOURCE_ROOT.

Following comments from https://codereview.chromium.org/14882007/,
let's keep it consistent with base/base_paths.

BUG=
TEST=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204357

[bulach, 2013-06-04 18:53:10]

ptal. since it has to be two-sided for downstream to catch up, there's no need
to block sami's patch for this.

[Sami, 2013-06-04 18:57:20]

lgtm. Thanks for the cleanup Marcus.

[Paweł Hajdan Jr., 2013-06-04 19:01:11]

LGTM

https://codereview.chromium.org/15979032/diff/1/build/android/pylib/constants.py
File build/android/pylib/constants.py (right):

https://codereview.chromium.org/15979032/diff/1/build/android/pylib/constants...
build/android/pylib/constants.py:12: # TODO(bulach): remove this.
This is totally fine for me for this CL.

Before I'd stamp https://codereview.chromium.org/14882007/ though, I'd just like
to see a CL which removes it.

[bulach, 2013-06-05 08:29:47]

thanks both!

Pawel: as I have mentioned before, the CL that will remove has to wait for this
to roll downstream.

again, I don't understand why you are coupling sami's patch with this change, so
please allow me to reframe:

- sami's patch adds a necessary functionality for running WebGL conformance
test.
- you have strong feelings for its one usage of CHROME_DIR.
- I have already sent you two out of three patches to fix that constant name,
and the third patch has to wait for this to roll.

- I fail to see any rationale why we are not going to be able to run WebGL
conformance tests due to a misnamed constant, which fix is already on its way...
:)

again, we are both agreeing that the constant needs to be renamed, I'm not
questioning it at all... however, I'm yet to understand why the hard-dependency?
these are clearly decoupled, whichever order we do, the end result would be the
same.

if we do it in parallel as I am suggesting, we'll be able to run the conformance
tests earlier.

if we do it serially as you're demanding, what exactly are we saving?

[bulach, 2013-06-05 10:00:22]

+frankf

[frankf, 2013-06-05 19:07:34]

lgtm

[bulach, 2013-06-05 19:11:24]

thanks all! CQing..

https://codereview.chromium.org/15979032/diff/1/build/android/pylib/constants.py
File build/android/pylib/constants.py (right):

https://codereview.chromium.org/15979032/diff/1/build/android/pylib/constants...
build/android/pylib/constants.py:12: # TODO(bulach): remove this.
On 2013/06/04 19:01:11, Paweł Hajdan Jr. wrote:
> This is totally fine for me for this CL.
> 
> Before I'd stamp https://codereview.chromium.org/14882007/ though, I'd just
like
> to see a CL which removes it.

as I said, the patch that removes it will come shortly after this has rolled.

[commit-bot: I haz the power, 2013-06-05 19:11:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bulach@chromium.org/15979032/1

[commit-bot: I haz the power, 2013-06-05 23:28:11]

Change committed as 204357