build/android/pylib/utils/findbugs.py - Issue 15979032: Android: renames pylib.constants.CHROME_DIR to DIR_SOURCE_ROOT.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/utils/findbugs.py

Issue 15979032: Android: renames pylib.constants.CHROME_DIR to DIR_SOURCE_ROOT. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/utils/findbugs.py

diff --git a/build/android/pylib/utils/findbugs.py b/build/android/pylib/utils/findbugs.py

index 995801a6a16d4d19714610508967f74c1c8709c6..bcc98c9ce3acdb93ba3d8af4116189a51bc587e5 100755

--- a/build/android/pylib/utils/findbugs.py

+++ b/build/android/pylib/utils/findbugs.py

@@ -72,7 +72,7 @@ def _GetChromeClasses(release_version):

version = 'Debug'

if release_version:

version = 'Release'

- path = os.path.join(constants.CHROME_DIR, 'out', version)

+ path = os.path.join(constants.DIR_SOURCE_ROOT, 'out', version)

cmd = 'find %s -name "*.class"' % path

out = cmd_helper.GetCmdOutput(shlex.split(cmd))

if not out:

@@ -98,7 +98,7 @@ def _Run(exclude, known_bugs, classes_to_analyze, auxiliary_classes,

findbug_args: addtional command line options needs pass to Findbugs.

"""

- chrome_src = constants.CHROME_DIR

+ chrome_src = constants.DIR_SOURCE_ROOT

sdk_root = constants.ANDROID_SDK_ROOT

sdk_version = constants.ANDROID_SDK_VERSION