Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: chrome/browser/resources/file_manager/manifest_new_ui.json

Issue 15975004: Replace sets with vectors when storing file handlers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/file_manager/manifest.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/file_manager/manifest_new_ui.json
diff --git a/chrome/browser/resources/file_manager/manifest_new_ui.json b/chrome/browser/resources/file_manager/manifest_new_ui.json
index c7413a6197ff0a52d39deb7c2fe3716da2204c88..3f4f822c9094ad7eed3744276e622b78ecde1dc1 100644
--- a/chrome/browser/resources/file_manager/manifest_new_ui.json
+++ b/chrome/browser/resources/file_manager/manifest_new_ui.json
@@ -32,35 +32,6 @@
"https://drive.google.com/"
],
"file_browser_handlers": [
- // Automatically opens a volume and later close Files.app when unmounted.
- // TODO(mtomasz): Implement a better filtering than using file_filters.
- {
- "id": "auto-open",
- "default_title": "__MSG_OPEN_ACTION__",
- "default_icon": "images/filetype_generic.png",
- "file_filters": [
- "filesystem:*"
- ]
- },
- // Selects the passed file after launching Files.app.
- {
- "id": "select",
- "default_title": "__MSG_OPEN_ACTION__",
- "default_icon": "images/filetype_generic.png",
- "file_filters": [
- "filesystem:*"
- ]
- },
- // Opens the passed directory after launching Files.app.
- // TODO(mtomasz): Implement a directories filtering instead of files.
- {
- "id": "open",
- "default_title": "__MSG_OPEN_ACTION__",
- "default_icon": "images/filetype_generic.png",
- "file_filters": [
- "filesystem:*"
- ]
- },
{
"id": "play",
"default_title": "__MSG_PLAY_MEDIA__",
@@ -208,6 +179,29 @@
"file_filters": [
"filesystem:*.gslides"
]
+ },
+ // The following handlers are used only internally, therefore they do not
+ // have any file filter.
+ // Automatically opens a volume and later close Files.app when unmounted.
+ {
+ "id": "auto-open",
+ "default_title": "__MSG_OPEN_ACTION__",
+ "default_icon": "images/filetype_generic.png",
+ "file_filters": []
+ },
+ // Selects the passed file after launching Files.app.
+ {
+ "id": "select",
+ "default_title": "__MSG_OPEN_ACTION__",
+ "default_icon": "images/filetype_generic.png",
+ "file_filters": []
+ },
+ // Opens the passed directory after launching Files.app.
+ {
+ "id": "open",
+ "default_title": "__MSG_OPEN_ACTION__",
+ "default_icon": "images/filetype_generic.png",
+ "file_filters": []
}
],
"chrome_url_overrides": {
« no previous file with comments | « chrome/browser/resources/file_manager/manifest.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698