Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7235)

Unified Diff: chrome/browser/resources/file_manager/manifest.json

Issue 15975004: Replace sets with vectors when storing file handlers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/file_manager/manifest.json
diff --git a/chrome/browser/resources/file_manager/manifest.json b/chrome/browser/resources/file_manager/manifest.json
index 1f6f482097f37dfb472b1cd200a813d7b89fcd51..42b53a7ce5e1bf1ee50a277d44fadba398ee67f7 100644
--- a/chrome/browser/resources/file_manager/manifest.json
+++ b/chrome/browser/resources/file_manager/manifest.json
@@ -31,35 +31,6 @@
"https://drive.google.com/"
],
"file_browser_handlers": [
- // Automatically opens a volume and later close Files.app when unmounted.
- // TODO(mtomasz): Implement a better filtering than using file_filters.
- {
- "id": "auto-open",
- "default_title": "__MSG_OPEN_ACTION__",
- "default_icon": "images/filetype_generic.png",
- "file_filters": [
- "filesystem:*"
- ]
- },
- // Selects the passed file after launching Files.app.
- {
- "id": "select",
- "default_title": "__MSG_OPEN_ACTION__",
- "default_icon": "images/filetype_generic.png",
- "file_filters": [
- "filesystem:*"
- ]
- },
- // Opens the passed directory after launching Files.app.
- // TODO(mtomasz): Implement a directories filtering instead of files.
- {
- "id": "open",
- "default_title": "__MSG_OPEN_ACTION__",
- "default_icon": "images/filetype_generic.png",
- "file_filters": [
- "filesystem:*"
- ]
- },
{
"id": "play",
"default_title": "__MSG_PLAY_MEDIA__",
@@ -207,6 +178,29 @@
"file_filters": [
"filesystem:*.gslides"
]
+ },
+ // The following handlers are used only internally, therefore they do not
+ // have any file filter.
+ // Automatically opens a volume and later close Files.app when unmounted.
+ {
+ "id": "auto-open",
+ "default_title": "__MSG_OPEN_ACTION__",
+ "default_icon": "images/filetype_generic.png",
+ "file_filters": []
+ },
+ // Selects the passed file after launching Files.app.
+ {
+ "id": "select",
+ "default_title": "__MSG_OPEN_ACTION__",
+ "default_icon": "images/filetype_generic.png",
+ "file_filters": []
+ },
+ // Opens the passed directory after launching Files.app.
+ {
+ "id": "open",
+ "default_title": "__MSG_OPEN_ACTION__",
+ "default_icon": "images/filetype_generic.png",
+ "file_filters": []
}
],
"chrome_url_overrides": {

Powered by Google App Engine
This is Rietveld 408576698