Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 159723009: Exclude extension settings strings for platforms that don't have extensions. (Closed)

Created:
6 years, 10 months ago by aurimas (slooooooooow)
Modified:
6 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Visibility:
Public.

Description

Exclude extension settings strings for platforms that don't have extensions. Removed the product name placeholder due to presumbit warning http://goo.gl/6614MQ. BUG=326023 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250841

Patch Set 1 #

Total comments: 2

Patch Set 2 : newt's nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -277 lines) Patch
M chrome/app/chromium_strings.grd View 1 1 chunk +8 lines, -3 lines 0 comments Download
M chrome/app/generated_resources.grd View 3 chunks +269 lines, -265 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +8 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
aurimas (slooooooooow)
pkasting: could you take a look at changes in chrome/browser/ui/*? newt: could you take a ...
6 years, 10 months ago (2014-02-12 01:21:40 UTC) #1
Peter Kasting
LGTM
6 years, 10 months ago (2014-02-12 01:57:25 UTC) #2
newt (away)
lgtm https://chromiumcodereview.appspot.com/159723009/diff/1/chrome/app/chromium_strings.grd File chrome/app/chromium_strings.grd (right): https://chromiumcodereview.appspot.com/159723009/diff/1/chrome/app/chromium_strings.grd#newcode779 chrome/app/chromium_strings.grd:779: Sign in to Chrome Chrome -> Chromium
6 years, 10 months ago (2014-02-12 19:08:18 UTC) #3
newt (away)
lgtm after Chrome -> Chromium change
6 years, 10 months ago (2014-02-12 19:08:35 UTC) #4
aurimas (slooooooooow)
https://chromiumcodereview.appspot.com/159723009/diff/1/chrome/app/chromium_strings.grd File chrome/app/chromium_strings.grd (right): https://chromiumcodereview.appspot.com/159723009/diff/1/chrome/app/chromium_strings.grd#newcode779 chrome/app/chromium_strings.grd:779: Sign in to Chrome On 2014/02/12 19:08:18, newt wrote: ...
6 years, 10 months ago (2014-02-12 19:14:03 UTC) #5
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 10 months ago (2014-02-12 19:15:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/159723009/110001
6 years, 10 months ago (2014-02-12 19:17:19 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-12 20:21:24 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=262698
6 years, 10 months ago (2014-02-12 20:21:26 UTC) #9
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 10 months ago (2014-02-12 21:48:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/159723009/110001
6 years, 10 months ago (2014-02-12 21:48:44 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-02-12 23:36:39 UTC) #12
Message was sent while issue was closed. 
Change committed as 250841

Powered by Google App Engine
This is Rietveld 408576698