Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

Issue 159723009: Exclude extension settings strings for platforms that don't have extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: newt's nit Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controlle r.h" 5 #import "chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controlle r.h"
6 6
7 #include "base/i18n/rtl.h" 7 #include "base/i18n/rtl.h"
8 #include "base/mac/bundle_locations.h" 8 #include "base/mac/bundle_locations.h"
9 #include "base/mac/mac_util.h" 9 #include "base/mac/mac_util.h"
10 #include "base/strings/sys_string_conversions.h" 10 #include "base/strings/sys_string_conversions.h"
(...skipping 422 matching lines...) Expand 10 before | Expand all | Expand 10 after
433 newWindowHeight += extension_installed_bubble::kInnerVerticalMargin; 433 newWindowHeight += extension_installed_bubble::kInnerVerticalMargin;
434 434
435 return newWindowHeight; 435 return newWindowHeight;
436 } 436 }
437 437
438 int sync_promo_height = 0; 438 int sync_promo_height = 0;
439 if ([self showSyncPromo]) { 439 if ([self showSyncPromo]) {
440 // First calculate the height of the sign-in promo. 440 // First calculate the height of the sign-in promo.
441 NSFont* font = [NSFont systemFontOfSize:[NSFont smallSystemFontSize]]; 441 NSFont* font = [NSFont systemFontOfSize:[NSFont smallSystemFontSize]];
442 442
443 NSString* link(l10n_util::GetNSStringFWithFixup( 443 NSString* link(l10n_util::GetNSStringWithFixup(
444 IDS_EXTENSION_INSTALLED_SIGNIN_PROMO_LINK, 444 IDS_EXTENSION_INSTALLED_SIGNIN_PROMO_LINK));
445 l10n_util::GetStringUTF16(IDS_SHORT_PRODUCT_NAME)));
446 NSString* message(l10n_util::GetNSStringWithFixup( 445 NSString* message(l10n_util::GetNSStringWithFixup(
447 IDS_EXTENSION_INSTALLED_SIGNIN_PROMO)); 446 IDS_EXTENSION_INSTALLED_SIGNIN_PROMO));
448 447
449 HyperlinkTextView* view = promo_.get(); 448 HyperlinkTextView* view = promo_.get();
450 [view setMessageAndLink:message 449 [view setMessageAndLink:message
451 withLink:link 450 withLink:link
452 atOffset:0 451 atOffset:0
453 font:font 452 font:font
454 messageColor:[NSColor blackColor] 453 messageColor:[NSColor blackColor]
455 linkColor:gfx::SkColorToCalibratedNSColor( 454 linkColor:gfx::SkColorToCalibratedNSColor(
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
696 ExtensionInstallUI::OpenAppInstalledUI(browser_->profile(), extension_->id()); 695 ExtensionInstallUI::OpenAppInstalledUI(browser_->profile(), extension_->id());
697 } 696 }
698 697
699 - (void)awakeFromNib { 698 - (void)awakeFromNib {
700 if (bundle_) 699 if (bundle_)
701 return; 700 return;
702 [self initializeLabel]; 701 [self initializeLabel];
703 } 702 }
704 703
705 @end 704 @end
OLDNEW
« no previous file with comments | « chrome/app/google_chrome_strings.grd ('k') | chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698