Don't add issue owner as reviewer if owner clicked commit box.

codereview/views_chromium.py

Index: codereview/views_chromium.py
===================================================================
--- a/codereview/views_chromium.py
+++ b/codereview/views_chromium.py
@@ -455,7 +455,11 @@
 
   if 'commit' in request.POST:
     request.issue.commit = form.cleaned_data['commit']
-    if request.user.email() not in request.issue.reviewers:
+    user_email = request.user.email().lower()

[iannucci, 2013/05/24 22:12:45]

why the .lower()?

[Mike Stip (use stip instead), 2013/05/24 22:26:31]

to better match the logic in lines 695-701 of views.py

+    if (user_email != request.issue.owner.email() and
+        user_email not in request.issue.reviewers and
+        user_email not in request.issue.cc and

[iannucci, 2013/05/24 22:12:45]

Actually we want ppl to get promoted from CC to reviewer.

[Mike Stip (use stip instead), 2013/05/24 22:26:31]

Done.

+        user_email not in request.issue.collaborator_emails()):
       request.issue.reviewers.append(db.Email(request.user.email()))
     request.issue.put()