Don't add issue owner as reviewer if owner clicked commit box.

codereview/views_chromium.py

 # Copyright 2008 Google Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
 #
 #     http://www.apache.org/licenses/LICENSE-2.0
 #
 # Unless required by applicable law or agreed to in writing, software
 # distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 437 matching lines @@
   form = EditFlagsForm(request.POST)
   if not form.is_valid():
     return HttpResponseBadRequest('Invalid POST arguments',
         content_type='text/plain')
   if (form.cleaned_data['last_patchset'] != last_patchset.key().id()):
     return HttpResponseForbidden('Can only modify flags on last patchset',
         content_type='text/plain')
 
   if 'commit' in request.POST:
     request.issue.commit = form.cleaned_data['commit']
-    if request.user.email() not in request.issue.reviewers:
+    user_email = request.user.email().lower()

[iannucci, 2013/05/24 22:12:45]

why the .lower()?

[Mike Stip (use stip instead), 2013/05/24 22:26:31]

to better match the logic in lines 695-701 of views.py

+    if (user_email != request.issue.owner.email() and
+        user_email not in request.issue.reviewers and
+        user_email not in request.issue.cc and

[iannucci, 2013/05/24 22:12:45]

Actually we want ppl to get promoted from CC to reviewer.

[Mike Stip (use stip instead), 2013/05/24 22:26:31]

Done.

+        user_email not in request.issue.collaborator_emails()):
       request.issue.reviewers.append(db.Email(request.user.email()))
     request.issue.put()
 
   if 'builders' in request.POST:
     def txn():
       jobs_to_save = []
       new_builders = filter(None, map(unicode.strip,
                                       form.cleaned_data['builders'].split(',')))
 
       # Add any new builders.
@@ skipping 377 matching lines @@
   q = models.TryJobResult.all().filter(
       'result =', models.TryJobResult.TRYPENDING).order('timestamp')
   if cursor:
     q.with_cursor(cursor)
 
   jobs = q.fetch(limit)
   total = len(jobs)
   jobs = [MakeJobDescription(job) for job in jobs if _is_job_valid(job)]
   logging.info('Found %d entries, returned %d' % (total, len(jobs)))
   return {'cursor': q.cursor(), 'jobs': jobs}