Don't add issue owner as reviewer if owner clicked commit box.

Don't add issue owner as reviewer if owner clicked commit box.

BUG=243770

[Mike Stip (use stip instead), 2013-05-24 21:33:29]

ptal

[iannucci, 2013-05-24 21:47:23]

https://chromiumcodereview.appspot.com/15962014/diff/1/codereview/views_chrom...
File codereview/views_chromium.py (right):

https://chromiumcodereview.appspot.com/15962014/diff/1/codereview/views_chrom...
codereview/views_chromium.py:459: request.user.email() != request.issue.owner):
should also check request.issue.is_collaborator(request.user)

[Mike Stip (use stip instead), 2013-05-24 21:53:29]

ppptttaaalll

[iannucci, 2013-05-24 22:12:45]

https://chromiumcodereview.appspot.com/15962014/diff/5001/codereview/views_ch...
File codereview/views_chromium.py (right):

https://chromiumcodereview.appspot.com/15962014/diff/5001/codereview/views_ch...
codereview/views_chromium.py:458: user_email = request.user.email().lower()
why the .lower()?

https://chromiumcodereview.appspot.com/15962014/diff/5001/codereview/views_ch...
codereview/views_chromium.py:461: user_email not in request.issue.cc and
Actually we want ppl to get promoted from CC to reviewer.

[Mike Stip (use stip instead), 2013-05-24 22:26:31]

ʃɐʇd

https://chromiumcodereview.appspot.com/15962014/diff/5001/codereview/views_ch...
File codereview/views_chromium.py (right):

https://chromiumcodereview.appspot.com/15962014/diff/5001/codereview/views_ch...
codereview/views_chromium.py:458: user_email = request.user.email().lower()
On 2013/05/24 22:12:45, iannucci wrote:
> why the .lower()?

to better match the logic in lines 695-701 of views.py

https://chromiumcodereview.appspot.com/15962014/diff/5001/codereview/views_ch...
codereview/views_chromium.py:461: user_email not in request.issue.cc and
On 2013/05/24 22:12:45, iannucci wrote:
> Actually we want ppl to get promoted from CC to reviewer.

Done.

[iannucci, 2013-05-24 22:44:50]

lgtm

[Mike Stip (use stip instead), 2013-05-24 22:46:46]

you want to commit?

[iannucci, 2013-05-24 22:48:21]

On 2013/05/24 22:44:50, iannucci wrote:
> lgtm

Committed:
https://code.google.com/p/rietveld/source/detail?r=19ae15dd45a0c2d0b871b2ec80...