chrome/renderer/extensions/scoped_persistent.h - Issue 15952012: remove remaining calls to old style MakeWeak

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/scoped_persistent.h

Issue 15952012: remove remaining calls to old style MakeWeak (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/scoped_persistent.h

diff --git a/chrome/renderer/extensions/scoped_persistent.h b/chrome/renderer/extensions/scoped_persistent.h

index 20925e4d8b73f9873c7da9b6e40ad1e916c68803..f8cedef5e006252aadd58c605dbd45560fbefded 100644

--- a/chrome/renderer/extensions/scoped_persistent.h

+++ b/chrome/renderer/extensions/scoped_persistent.h

@@ -45,7 +45,9 @@ class ScopedPersistent {

return handle_;

}

- void MakeWeak(void* parameters, v8::NearDeathCallback callback) {

+ template<typename P>

+ void MakeWeak(P* parameters,

+ typename v8::WeakReferenceCallbacks<T, P>::Revivable callback) {

handle_.MakeWeak(GetIsolate(handle_), parameters, callback);

}