Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: chrome/renderer/extensions/miscellaneous_bindings.cc

Issue 15952012: remove remaining calls to old style MakeWeak (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/extensions/scoped_persistent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/miscellaneous_bindings.cc
diff --git a/chrome/renderer/extensions/miscellaneous_bindings.cc b/chrome/renderer/extensions/miscellaneous_bindings.cc
index cf538c7ad315d108a1bed9538f8b47238b19cb13..d40d517ed4ee8e18adb792a68adadd630f689296 100644
--- a/chrome/renderer/extensions/miscellaneous_bindings.cc
+++ b/chrome/renderer/extensions/miscellaneous_bindings.cc
@@ -164,10 +164,9 @@ class ExtensionImpl : public extensions::ChromeV8Extension {
};
static void GCCallback(v8::Isolate* isolate,
- v8::Persistent<v8::Value> object,
- void* parameter) {
+ v8::Persistent<v8::Object>* object,
+ GCCallbackArgs* args) {
v8::HandleScope handle_scope;
- GCCallbackArgs* args = static_cast<GCCallbackArgs*>(parameter);
v8::Handle<v8::Context> context = args->callback->CreationContext();
v8::Context::Scope context_scope(context);
WebKit::WebScopedMicrotaskSuppression suppression;
« no previous file with comments | « no previous file | chrome/renderer/extensions/scoped_persistent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698