Move application restart and relaunch code out of ExtensionService.

Move application restart and relaunch code out of ExtensionService.

This apps specific code now lives in AppLoadService in the apps/
component.

BUG=159366, 159265, 175381
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203382

[benwells, 2013-05-29 07:40:03]

just koz for initial review, will get owners when have lgtk.

[koz (OOO until 15th September), 2013-05-29 08:08:10]

https://codereview.chromium.org/15947007/diff/6001/apps/app_load_service.h
File apps/app_load_service.h (right):

https://codereview.chromium.org/15947007/diff/6001/apps/app_load_service.h#ne...
apps/app_load_service.h:33: //
missing end of comment

[koz (OOO until 15th September), 2013-05-30 00:22:22]

lgtm

https://codereview.chromium.org/15947007/diff/6001/apps/app_load_service.h
File apps/app_load_service.h (right):

https://codereview.chromium.org/15947007/diff/6001/apps/app_load_service.h#ne...
apps/app_load_service.h:33: //
On 2013/05/29 08:08:10, koz wrote:
> missing end of comment

Also, there's no |extension_path| parameter.

https://codereview.chromium.org/15947007/diff/6001/chrome/browser/extensions/...
File chrome/browser/extensions/unpacked_installer.h (right):

https://codereview.chromium.org/15947007/diff/6001/chrome/browser/extensions/...
chrome/browser/extensions/unpacked_installer.h:45: // optionally launches the
extension once it's loaded.
This function no longer optionally launches the extension once it's loaded so
this part of the comment is no longer valid. Also, it says that it runs
synchronously, but the new call site seems to behave as if it is asynchronous,
ie:

std::string extension_id;
LoadFromCommandLine(..., &extension_id);
ScheduleLaunchOnLoad(extension_id);  // Assumes extension_id not loaded yet.

It seems that it synchronously loads the extension off the disk, but
asynchronously "loads" the extension. Maybe just amend this comment by saying

"This is equivalent to Load, except that it reads the extension from
|extension_path| synchronously."

[benwells, 2013-05-30 01:47:42]

+sky for owners review of
* chrome/browser/background
* chrome/browser/profiles
* chrome/browser/tab_contents
* chrome/browser/ui/startup
* chrome/browser/ui/extensions
* chrome/common
(i.e. everything except apps/ and chrome/browser/extensions)

+yoz cc for info, feel free to review if you want.

https://codereview.chromium.org/15947007/diff/6001/apps/app_load_service.h
File apps/app_load_service.h (right):

https://codereview.chromium.org/15947007/diff/6001/apps/app_load_service.h#ne...
apps/app_load_service.h:33: //
On 2013/05/30 00:22:22, koz wrote:
> On 2013/05/29 08:08:10, koz wrote:
> > missing end of comment
> 
> Also, there's no |extension_path| parameter.

Done.

https://codereview.chromium.org/15947007/diff/6001/chrome/browser/extensions/...
File chrome/browser/extensions/unpacked_installer.h (right):

https://codereview.chromium.org/15947007/diff/6001/chrome/browser/extensions/...
chrome/browser/extensions/unpacked_installer.h:45: // optionally launches the
extension once it's loaded.
On 2013/05/30 00:22:22, koz wrote:
> This function no longer optionally launches the extension once it's loaded so
> this part of the comment is no longer valid. Also, it says that it runs
> synchronously, but the new call site seems to behave as if it is asynchronous,
> ie:
> 
> std::string extension_id;
> LoadFromCommandLine(..., &extension_id);
> ScheduleLaunchOnLoad(extension_id);  // Assumes extension_id not loaded yet.
> 
> It seems that it synchronously loads the extension off the disk, but
> asynchronously "loads" the extension. Maybe just amend this comment by saying
> 
> "This is equivalent to Load, except that it reads the extension from
> |extension_path| synchronously."

Done.

[sky, 2013-05-30 15:33:32]

LGTM

https://codereview.chromium.org/15947007/diff/18001/chrome/browser/ui/startup...
File chrome/browser/ui/startup/startup_browser_creator.cc (right):

https://codereview.chromium.org/15947007/diff/18001/chrome/browser/ui/startup...
chrome/browser/ui/startup/startup_browser_creator.cc:634: extension_id);
nit: indent 2 more spaces.

[Yoyo Zhou, 2013-05-30 17:29:34]

LGTM
though I don't think this actually is related to bug 179951.

https://codereview.chromium.org/15947007/diff/18001/chrome/browser/extensions...
File chrome/browser/extensions/unpacked_installer.h (right):

https://codereview.chromium.org/15947007/diff/18001/chrome/browser/extensions...
chrome/browser/extensions/unpacked_installer.h:44: // This is equivalent to
Load, except that it runs reads the extension
nit: delete 'runs'

[benwells, 2013-05-31 01:13:03]

Oh yeah, wrong bug. I've put the more generic extensions bug on, which I think
this helps with.

https://codereview.chromium.org/15947007/diff/18001/chrome/browser/extensions...
File chrome/browser/extensions/unpacked_installer.h (right):

https://codereview.chromium.org/15947007/diff/18001/chrome/browser/extensions...
chrome/browser/extensions/unpacked_installer.h:44: // This is equivalent to
Load, except that it runs reads the extension
On 2013/05/30 17:29:34, Yoyo Zhou wrote:
> nit: delete 'runs'

Done.

https://codereview.chromium.org/15947007/diff/18001/chrome/browser/ui/startup...
File chrome/browser/ui/startup/startup_browser_creator.cc (right):

https://codereview.chromium.org/15947007/diff/18001/chrome/browser/ui/startup...
chrome/browser/ui/startup/startup_browser_creator.cc:634: extension_id);
On 2013/05/30 15:33:32, sky wrote:
> nit: indent 2 more spaces.

Done.

[commit-bot: I haz the power, 2013-05-31 01:13:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benwells@chromium.org/15947007/25001

[commit-bot: I haz the power, 2013-05-31 03:40:52]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-05-31 06:56:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benwells@chromium.org/15947007/41001

[commit-bot: I haz the power, 2013-05-31 09:37:56]

Change committed as 203382