Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2448)

Unified Diff: chrome/browser/extensions/extension_service.h

Issue 15947007: Move application restart and relaunch code out of ExtensionService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Pafooey Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.h
diff --git a/chrome/browser/extensions/extension_service.h b/chrome/browser/extensions/extension_service.h
index ea62a5b53ffe5cb08e004480a67a7014d0fd325d..2de0c40fe502e9e2ff29955edf82a740dbe7d534 100644
--- a/chrome/browser/extensions/extension_service.h
+++ b/chrome/browser/extensions/extension_service.h
@@ -328,9 +328,6 @@ class ExtensionService
// currently has any window showing.
void ReloadExtension(const std::string& extension_id);
- // Reloads an extension and sends it the onRestarted() event.
- void RestartExtension(const std::string& extension_id);
-
// Uninstalls the specified extension. Callers should only call this method
// with extensions that exist. |external_uninstall| is a magical parameter
// that is only used to send information to ExtensionPrefs, which external
@@ -419,9 +416,6 @@ class ExtensionService
virtual void AddComponentExtension(const extensions::Extension* extension)
OVERRIDE;
- // Launch an extension the next time it is loaded.
- void ScheduleLaunchOnLoad(const std::string& extension_id);
-
// Informs the service that an extension's files are in place for loading.
//
// Please make sure the Blacklist is checked some time before calling this
@@ -719,13 +713,6 @@ class ExtensionService
const extensions::ExtensionSyncData& extension_sync_data,
syncer::ModelType type);
- // Events to be fired after an extension is reloaded.
- enum PostReloadEvents {
- EVENT_NONE = 0,
- EVENT_LAUNCHED = 1 << 0,
- EVENT_RESTARTED = 1 << 1,
- };
-
// Adds the given extension to the list of terminated extensions if
// it is not already there and unloads it.
void TrackTerminatedExtension(const extensions::Extension* extension);
@@ -752,11 +739,6 @@ class ExtensionService
// Common helper to finish installing the given extension.
void FinishInstallation(const extensions::Extension* extension);
- // Reloads |extension_id| and then dispatches to it the PostReloadEvents
- // indicated by |events|.
- void ReloadExtensionWithEvents(const std::string& extension_id,
- int events);
-
// Updates the |extension|'s active permission set to include only permissions
// currently requested by the extension and all the permissions required by
// the extension.
@@ -767,9 +749,6 @@ class ExtensionService
void CheckPermissionsIncrease(const extensions::Extension* extension,
bool is_upgrade);
- // Returns true if the app with id |extension_id| has any shell windows open.
- bool HasShellWindows(const std::string& extension_id);
-
// Helper that updates the active extension list used for crash reporting.
void UpdateActiveExtensionsInCrashReporter();
@@ -788,16 +767,6 @@ class ExtensionService
NaClModuleInfoList::iterator FindNaClModule(const GURL& url);
- // Performs tasks requested to occur after |extension| loads.
- void DoPostLoadTasks(const extensions::Extension* extension);
-
- // Launches the platform app associated with |extension_host|.
- static void LaunchApplication(extensions::ExtensionHost* extension_host);
-
- // Dispatches a restart event to the platform app associated with
- // |extension_host|.
- static void RestartApplication(extensions::ExtensionHost* extension_host);
-
// Helper to inspect an ExtensionHost after it has been loaded.
void InspectExtensionHost(extensions::ExtensionHost* host);
@@ -916,10 +885,6 @@ class ExtensionService
typedef std::map<std::string, std::string> OrphanedDevTools;
OrphanedDevTools orphaned_dev_tools_;
- // Maps extension ids to a bitmask that indicates which events should be
- // dispatched to the extension when it is loaded.
- std::map<std::string, int> on_load_events_;
-
content::NotificationRegistrar registrar_;
PrefChangeRegistrar pref_change_registrar_;

Powered by Google App Engine
This is Rietveld 408576698