Case-insensitive search for non-ASCII characters in auto-complete of Drive files.

Case-insensitive search for non-ASCII characters in auto-complete of Drive files.

At the same time, it changes the behavior to highlight only
the first occurrence of the query pattern. I believe it is ok,
because (1) drive.google.com highlights in that way (2) it is
sufficient for users to know why the file is suggested.

BUG=173948
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202409

[kinaba, 2013-05-27 04:49:25]

Please take a look.

To match with the i18n::StringSearchIgnoringCaseAndAccents interface
I changed the behavior of highlighting so that it only cares
the first occurrence, but I think it is fine (as wrote in the CL description).
What do you think?

[satorux1, 2013-05-27 05:00:24]

LGTM with nits:

https://codereview.chromium.org/15945004/diff/2001/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/search_metadata.cc (right):

https://codereview.chromium.org/15945004/diff/2001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/search_metadata.cc:222: size_t match_start,
match_length;
nit: initialize them with 0 to be extra defensive.

https://codereview.chromium.org/15945004/diff/2001/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/search_metadata.h (right):

https://codereview.chromium.org/15945004/diff/2001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/search_metadata.h:35: // Finds |query| in |text|
while ignoring case. Returns true if |query| is
please mention that non-ASCII characters are supported.

BTW, does this perform any normalization against hiragana/katakana? If so, it'd
be nice to add some tests.

[kinaba, 2013-05-27 05:50:26]

https://codereview.chromium.org/15945004/diff/2001/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/search_metadata.cc (right):

https://codereview.chromium.org/15945004/diff/2001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/search_metadata.cc:222: size_t match_start,
match_length;
On 2013/05/27 05:00:24, satorux1 wrote:
> nit: initialize them with 0 to be extra defensive.

Done.

https://codereview.chromium.org/15945004/diff/2001/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/search_metadata.h (right):

https://codereview.chromium.org/15945004/diff/2001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/search_metadata.h:35: // Finds |query| in |text|
while ignoring case. Returns true if |query| is
On 2013/05/27 05:00:24, satorux1 wrote:
> please mention that non-ASCII characters are supported.
> 
> BTW, does this perform any normalization against hiragana/katakana? If so,
it'd
> be nice to add some tests.

It does. Added a test.

[commit-bot: I haz the power, 2013-05-27 07:19:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/15945004/14001

[commit-bot: I haz the power, 2013-05-27 13:14:23]

Change committed as 202409