Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: chrome/browser/chromeos/drive/search_metadata.h

Issue 15945004: Case-insensitive search for non-ASCII characters in auto-complete of Drive files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fix. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/drive/search_metadata.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/drive/search_metadata.h
diff --git a/chrome/browser/chromeos/drive/search_metadata.h b/chrome/browser/chromeos/drive/search_metadata.h
index dbe0ae2466252675e5c83b40ac79cee2b1d636f9..62cca4965dd642488973649ff0a145f4b3174c37 100644
--- a/chrome/browser/chromeos/drive/search_metadata.h
+++ b/chrome/browser/chromeos/drive/search_metadata.h
@@ -32,11 +32,13 @@ void SearchMetadata(
int at_most_num_matches,
const SearchMetadataCallback& callback);
-// Finds |query| in |text| while ignoring case. Returns true if |query| is
-// found. Returns false if |query| is not found, or empty. |highlighted_text|
-// will have the original text with matched portions highlighted with <b> tag
-// (multiple portions can be highlighted). Meta characters are escaped like
-// &lt;. The original contents of |highlighted| will be lost.
+// Finds |query| in |text| while ignoring cases or accents. Cases of non-ASCII
+// characters are also ignored; they are compared in the 'Primary Level' of
+// http://userguide.icu-project.org/collation/concepts.
+// Returns true if |query| is found. |highlighted_text| will have the original
+// text with matched portions highlighted with <b> tag (only the first match
+// is highlighted). Meta characters are escaped like &lt;. The original
+// contents of |highlighted| will be lost.
bool FindAndHighlight(const std::string& text,
const std::string& query,
std::string* highlighted_text);
« no previous file with comments | « no previous file | chrome/browser/chromeos/drive/search_metadata.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698