Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 15944007: Fix cross-window focus in Chrome Frame. (Closed)

Created:
7 years, 7 months ago by grt (UTC plus 2)
Modified:
7 years, 7 months ago
CC:
chromium-reviews, tfarina, amit, robertshield, grt+watch_chromium.org
Visibility:
Public.

Description

Fix cross-window focus in Chrome Frame. Text input wasn't working due to requirements of the IME/TSF machinery that weren't being met by ExternalTabContainerWin. * ExternalTabContainerWin now provides an implementation for WebContentsDelegate::WebContentsFocused that calls into its WebView's OnWebContentsFocused method. This mimics BrowserView, and permits proper focus tracking via the FocusManager. * ExternalTabContainerWin now provides a specialization of DesktopRootWindowHostWin that saves and restores focus on blur/focus events. The stock DRWHW does this based on window activation, but this doesn't work for ETCW since the ETCW's DRWHW doesn't receive activation messages due to it being a child of an IE window rather than a top-level window. * IEEventSink::SendKeys now sets focus to the renderer before sending key down/up messages. BUG=241081 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202270

Patch Set 1 #

Patch Set 2 : only open popups once #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -13 lines) Patch
M chrome/browser/ui/views/external_tab_container_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/external_tab_container_win.cc View 4 chunks +42 lines, -1 line 0 comments Download
M chrome_frame/test/data/window_open.html View 1 1 chunk +4 lines, -2 lines 0 comments Download
M chrome_frame/test/ie_event_sink.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome_frame/test/navigation_test.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome_frame/test/simulate_input.cc View 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
grt (UTC plus 2)
sky: chrome/browser/ui/views erikwright: chrome_frame Please redirect as appropriate. Thanks.
7 years, 7 months ago (2013-05-24 18:41:15 UTC) #1
erikwright (departed)
chrome_frame LGTM.
7 years, 7 months ago (2013-05-24 18:56:49 UTC) #2
sky
LGTM
7 years, 7 months ago (2013-05-24 20:25:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/15944007/2001
7 years, 7 months ago (2013-05-24 22:10:23 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=118417
7 years, 7 months ago (2013-05-25 03:48:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/15944007/2001
7 years, 7 months ago (2013-05-25 12:03:29 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-25 13:58:31 UTC) #7
Message was sent while issue was closed.
Change committed as 202270

Powered by Google App Engine
This is Rietveld 408576698