chrome_frame/test/data/window_open.html - Issue 15944007: Fix cross-window focus in Chrome Frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_frame/test/data/window_open.html

Issue 15944007: Fix cross-window focus in Chrome Frame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: only open popups once Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome_frame/test/data/window_open.html

diff --git a/chrome_frame/test/data/window_open.html b/chrome_frame/test/data/window_open.html

index 7708491140686ec72d431dc8a1960ec308d43035..2478c429acc06cb8a6d0ef03f13deb36d1ef643b 100644

--- a/chrome_frame/test/data/window_open.html

+++ b/chrome_frame/test/data/window_open.html

@@ -7,8 +7,10 @@

function OnClick() {

// Open popup to the url from the given query string.

var url = window.location.search.substring(1);

- new_window = window.open(url, "_blank",

- "left=10, top=10, height=250, width=250");

+ if (!new_window) {

+ new_window = window.open(url, "_blank",

+ "left=10, top=10, height=250, width=250");

+ }

}

function OnKeyPress() {