Issue 15943008: [binding] Replace [CustomIndexedGetter] attributes with [Custom] getter

Issue 15943008: [binding] Replace [CustomIndexedGetter] attributes with [Custom] getter (Closed)

Created:
7 years, 7 months ago by kojih

Modified:
7 years, 7 months ago

Reviewers:
haraken

CC:
blink-reviews, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, haraken, Nate Chapin, alancutter (OOO until 2018)

Base URL:
https://chromium.googlesource.com/chromium/blink@master

Visibility:
Public.

More Reviews

Description

[binding] Replace [CustomIndexedGetter] attributes with [Custom] getter Remove following attributes so that we can process IDLs more unified way: -CustomDeleteProperty -CustomIndexedGetter -CustomIndexedSetter -CustomNamedGetter -CustomNamedSetter R=haraken@chromium.org BUG=240176 TEST=TestCustomAccessors.idl, TestInterface.idl, TestTypedArray.idl Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151233

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Patch Set 3 : update tests #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+147 lines, -106 lines)			Patch
M	Source/bindings/scripts/CodeGeneratorV8.pm	View	1	10 chunks	+113 lines, -71 lines	0 comments	Download
M	Source/bindings/scripts/IDLAttributes.txt	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	Source/bindings/tests/idls/TestCustomAccessors.idl	View		1 chunk	+6 lines, -5 lines	0 comments	Download
M	Source/bindings/tests/idls/TestInterface.idl	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/tests/idls/TestTypedArray.idl	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8Float64Array.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/bindings/tests/results/V8Float64Array.cpp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestCustomAccessors.cpp	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/css/StyleSheetList.idl	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/DOMStringMap.idl	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLAllCollection.idl	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLAppletElement.idl	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/html/HTMLEmbedElement.idl	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/html/HTMLObjectElement.idl	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/html/HTMLOptionsCollection.idl	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLSelectElement.idl	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	Source/core/page/DOMWindow.idl	View		2 chunks	+1 line, -1 line	0 comments	Download
M	Source/core/storage/Storage.idl	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kojih

r? Diff of generated code (all changes are removing unused code): diff -u /mnt/hdd/diff/gen_stt/V8DOMStringMap.h /mnt/hdd/diff/gen_sti/V8DOMStringMap.h ...

7 years, 7 months ago (2013-05-28 04:34:59 UTC) #1

r?

Diff of generated code (all changes are removing unused code):
diff -u /mnt/hdd/diff/gen_stt/V8DOMStringMap.h
/mnt/hdd/diff/gen_sti/V8DOMStringMap.h
--- /mnt/hdd/diff/gen_stt/V8DOMStringMap.h      2013-05-28 11:51:18.777024748
+0900
+++ /mnt/hdd/diff/gen_sti/V8DOMStringMap.h      2013-05-28 13:21:58.659992917
+0900
@@ -40,7 +40,6 @@
     static void derefObject(void*);
     static WrapperTypeInfo info;
     static void* opaqueRootForGC(void*, v8::Persistent<v8::Object>,
v8::Isolate*);
-    static v8::Handle<v8::Boolean> indexedPropertyDeleter(uint32_t, const
v8::AccessorInfo&);
     static v8::Handle<v8::Value> namedPropertyGetter(v8::Local<v8::String>,
const v8::AccessorInfo&);
     static v8::Handle<v8::Value> namedPropertySetter(v8::Local<v8::String>,
v8::Local<v8::Value>, const v8::AccessorInfo&);
     static v8::Handle<v8::Boolean> namedPropertyDeleter(v8::Local<v8::String>,
const v8::AccessorInfo&);
diff -u /mnt/hdd/diff/gen_stt/V8HTMLAppletElement.cpp
/mnt/hdd/diff/gen_sti/V8HTMLAppletElement.cpp
--- /mnt/hdd/diff/gen_stt/V8HTMLAppletElement.cpp       2013-05-28
11:51:18.747024510 +0900
+++ /mnt/hdd/diff/gen_sti/V8HTMLAppletElement.cpp       2013-05-28
13:21:58.629992681 +0900
@@ -26,7 +26,6 @@
 #include "V8HTMLElement.h"
 #include "bindings/v8/ScriptController.h"
 #include "bindings/v8/V8Binding.h"
-#include "bindings/v8/V8Collection.h"
 #include "bindings/v8/V8DOMConfiguration.h"
 #include "bindings/v8/V8DOMWrapper.h"
 #include "core/dom/ContextFeatures.h"
diff -u /mnt/hdd/diff/gen_stt/V8HTMLEmbedElement.cpp
/mnt/hdd/diff/gen_sti/V8HTMLEmbedElement.cpp
--- /mnt/hdd/diff/gen_stt/V8HTMLEmbedElement.cpp        2013-05-28
11:51:18.747024510 +0900
+++ /mnt/hdd/diff/gen_sti/V8HTMLEmbedElement.cpp        2013-05-28
13:21:58.629992681 +0900
@@ -28,7 +28,6 @@
 #include "bindings/v8/BindingSecurity.h"
 #include "bindings/v8/ScriptController.h"
 #include "bindings/v8/V8Binding.h"
-#include "bindings/v8/V8Collection.h"
 #include "bindings/v8/V8DOMConfiguration.h"
 #include "bindings/v8/V8DOMWrapper.h"
 #include "core/dom/ContextFeatures.h"
diff -u /mnt/hdd/diff/gen_stt/V8HTMLObjectElement.cpp
/mnt/hdd/diff/gen_sti/V8HTMLObjectElement.cpp
--- /mnt/hdd/diff/gen_stt/V8HTMLObjectElement.cpp       2013-05-28
11:51:18.747024510 +0900
+++ /mnt/hdd/diff/gen_sti/V8HTMLObjectElement.cpp       2013-05-28
13:21:58.629992681 +0900
@@ -31,7 +31,6 @@
 #include "bindings/v8/BindingSecurity.h"
 #include "bindings/v8/ScriptController.h"
 #include "bindings/v8/V8Binding.h"
-#include "bindings/v8/V8Collection.h"
 #include "bindings/v8/V8DOMConfiguration.h"
 #include "bindings/v8/V8DOMWrapper.h"
 #include "core/dom/ContextFeatures.h"

haraken

LGTM https://codereview.chromium.org/15943008/diff/1/Source/core/html/HTMLAllCollection.idl File Source/core/html/HTMLAllCollection.idl (right): https://codereview.chromium.org/15943008/diff/1/Source/core/html/HTMLAllCollection.idl#newcode33 Source/core/html/HTMLAllCollection.idl:33: [ImplementedAs=item] getter Node (unsigned long index); Just to ...

7 years, 7 months ago (2013-05-28 04:44:17 UTC) #2

kojih

https://codereview.chromium.org/15943008/diff/1/Source/core/html/HTMLAllCollection.idl File Source/core/html/HTMLAllCollection.idl (right): https://codereview.chromium.org/15943008/diff/1/Source/core/html/HTMLAllCollection.idl#newcode33 Source/core/html/HTMLAllCollection.idl:33: [ImplementedAs=item] getter Node (unsigned long index); On 2013/05/28 04:44:17, ...

7 years, 7 months ago (2013-05-28 04:52:02 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kojih@chromium.org/15943008/8001

7 years, 7 months ago (2013-05-28 07:49:04 UTC) #4

Message was sent while issue was closed.

Change committed as 151233

Expand Messages | Collapse Messages