Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 15942008: Remove unused includes from core/inspector and core/svg .cpp files (Closed)

Created:
7 years, 6 months ago by Timothy Loh
Modified:
7 years, 6 months ago
Reviewers:
pdr., pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, Steve Block, loislo+blink_chromium.org, alancutter (OOO until 2018), eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dstockwell, shans, apavlov+blink_chromium.org, darktears, pdr, f(malita), Stephen Chennney, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Remove unused includes from core/inspector and core/svg .cpp files Splitting up codereview.chromium.org/15447002 into smaller patches. BUG=242216 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151530

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase and address pdr's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -296 lines) Patch
M Source/core/inspector/ConsoleMessage.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/ContentSearchUtils.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/DOMEditor.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/DOMPatchSupport.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InjectedScript.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/inspector/InjectedScriptCanvasModule.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InjectedScriptHost.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/core/inspector/InspectorAgent.cpp View 1 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/inspector/InspectorApplicationCacheAgent.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 3 chunks +0 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorCanvasAgent.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorClient.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorController.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 4 chunks +0 lines, -24 lines 0 comments Download
M Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorDOMStorageAgent.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDatabaseAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorDatabaseResource.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorFileSystemAgent.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorFrontendHost.cpp View 1 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorIndexedDBAgent.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorInputAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorLayerTreeAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorMemoryAgent.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorOverlay.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorResourceAgent.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorWorkerAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/PageConsoleAgent.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/inspector/PageDebuggerAgent.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/PageRuntimeAgent.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/ScriptCallFrame.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/inspector/ScriptCallStack.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/ScriptProfile.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/TimelineRecordFactory.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/WorkerInspectorController.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGAltGlyphElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAnimateElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAnimateMotionElement.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAnimateTransformElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGAnimationElement.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/svg/SVGCircleElement.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/svg/SVGClipPathElement.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/svg/SVGColor.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGCursorElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGDocumentExtensions.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/svg/SVGElementInstance.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/svg/SVGEllipseElement.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/svg/SVGExternalResourcesRequired.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEBlendElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEColorMatrixElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEComponentTransferElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFECompositeElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEConvolveMatrixElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEDiffuseLightingElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEDisplacementMapElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEDropShadowElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEFloodElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEGaussianBlurElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEImageElement.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFELightElement.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFEMergeNodeElement.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/svg/SVGFEMorphologyElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEOffsetElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFESpecularLightingElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFETileElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFETurbulenceElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFilterElement.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFontElement.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFontFaceUriElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGForeignObjectElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGGlyphElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGGlyphRefElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGHKernElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGImageElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGImageLoader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGLangSpace.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGLength.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGLineElement.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/svg/SVGLinearGradientElement.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/svg/SVGMarkerElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGMaskElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPaint.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGPathByteStreamBuilder.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGPathElement.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathUtilities.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPatternElement.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/svg/SVGPolyElement.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/svg/SVGRadialGradientElement.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/svg/SVGRectElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGScriptElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGStopElement.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/svg/SVGStyleElement.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/svg/SVGStyledLocatableElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGStyledTransformableElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGTSpanElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGTests.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGTextContentElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGTextElement.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/svg/SVGTextPathElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGTextPositioningElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGTransform.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGTransformDistance.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGTransformable.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/svg/SVGURIReference.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M Source/core/svg/SVGVKernElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGViewElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/animation/SMILTimeContainer.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Timothy Loh
7 years, 6 months ago (2013-05-30 05:20:49 UTC) #1
pfeldman
not lgtm. 1) change claims to affect inspector and svg, but affects entire core/ 2) ...
7 years, 6 months ago (2013-05-30 10:34:58 UTC) #2
Timothy Loh
On 2013/05/30 10:34:58, pfeldman wrote: > not lgtm. > 1) change claims to affect inspector ...
7 years, 6 months ago (2013-05-30 13:35:53 UTC) #3
pfeldman
Hm, you are right, I confused the two links from the email. Inspector part lgtm. ...
7 years, 6 months ago (2013-05-30 14:14:52 UTC) #4
Timothy Loh
On 2013/05/30 14:14:52, pfeldman wrote: > Hm, you are right, I confused the two links ...
7 years, 6 months ago (2013-05-30 15:26:39 UTC) #5
pdr.
LGTM with nits for the SVG files. Please wait for Pavel's response for the inspector ...
7 years, 6 months ago (2013-05-31 02:15:21 UTC) #6
Timothy Loh
On 2013/05/31 02:15:21, pdr wrote: > LGTM with nits for the SVG files. Updated for ...
7 years, 6 months ago (2013-05-31 05:07:00 UTC) #7
pdr.
On 2013/05/31 05:07:00, Timothy Loh wrote: > On 2013/05/31 02:15:21, pdr wrote: > > LGTM ...
7 years, 6 months ago (2013-05-31 05:08:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/15942008/7001
7 years, 6 months ago (2013-05-31 05:10:52 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-05-31 08:05:08 UTC) #10
Message was sent while issue was closed.
Change committed as 151530

Powered by Google App Engine
This is Rietveld 408576698