Issue 15941016: Move field index into property details, freeing up the value slot of fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15941016: Move field index into property details, freeing up the value slot of fields. (Closed)

Created:
7 years, 6 months ago by Toon Verwaest

Modified:
7 years, 6 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Move field index into property details, freeing up the value slot of fields. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14909

Patch Set 2 : Addressed comments #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -23 lines)			Patch
M	src/handles.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/json-stringifier.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/objects-inl.h	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	src/property.h	View		6 chunks	+13 lines, -13 lines	0 comments	Download
M	src/property-details.h	View	1	3 chunks	+15 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with a comment https://codereview.chromium.org/15941016/diff/1/src/property-details.h File src/property-details.h (right): https://codereview.chromium.org/15941016/diff/1/src/property-details.h#newcode238 src/property-details.h:238: class DeletedField: public BitField<uint32_t, 6, ...

7 years, 6 months ago (2013-05-31 16:44:14 UTC) #2

Toon Verwaest

7 years, 6 months ago (2013-05-31 19:11:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r14909 (presubmit successful).

Expand Messages | Collapse Messages

Issue 15941016: Move field index into property details, freeing up the value slot of fields. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comments #

Messages