Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/objects.cc

Issue 15941016: Move field index into property details, freeing up the value slot of fields. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/json-stringifier.h ('k') | src/objects-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2479 matching lines...) Expand 10 before | Expand all | Expand 10 after
2490 Map* next = transitions->GetTarget(transition); 2490 Map* next = transitions->GetTarget(transition);
2491 DescriptorArray* next_descriptors = next->instance_descriptors(); 2491 DescriptorArray* next_descriptors = next->instance_descriptors();
2492 2492
2493 if (next_descriptors->GetValue(i) != descriptors->GetValue(i)) break; 2493 if (next_descriptors->GetValue(i) != descriptors->GetValue(i)) break;
2494 2494
2495 PropertyDetails details = descriptors->GetDetails(i); 2495 PropertyDetails details = descriptors->GetDetails(i);
2496 PropertyDetails next_details = next_descriptors->GetDetails(i); 2496 PropertyDetails next_details = next_descriptors->GetDetails(i);
2497 if (details.type() != next_details.type()) break; 2497 if (details.type() != next_details.type()) break;
2498 if (details.attributes() != next_details.attributes()) break; 2498 if (details.attributes() != next_details.attributes()) break;
2499 if (!details.representation().Equals(next_details.representation())) break; 2499 if (!details.representation().Equals(next_details.representation())) break;
2500 ASSERT(!details.IsDeleted());
2501 ASSERT(!next_details.IsDeleted());
2502 2500
2503 current = next; 2501 current = next;
2504 } 2502 }
2505 return current; 2503 return current;
2506 } 2504 }
2507 2505
2508 2506
2509 // Generalize the representation of the descriptor at |modify_index|. 2507 // Generalize the representation of the descriptor at |modify_index|.
2510 // This method rewrites the transition tree to reflect the new change. To avoid 2508 // This method rewrites the transition tree to reflect the new change. To avoid
2511 // high degrees over polymorphism, and to stabilize quickly, on every rewrite 2509 // high degrees over polymorphism, and to stabilize quickly, on every rewrite
(...skipping 13125 matching lines...) Expand 10 before | Expand all | Expand 10 after
15637 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER); 15635 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER);
15638 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER); 15636 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER);
15639 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER); 15637 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER);
15640 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER); 15638 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER);
15641 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER); 15639 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER);
15642 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER); 15640 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER);
15643 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER); 15641 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER);
15644 } 15642 }
15645 15643
15646 } } // namespace v8::internal 15644 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/json-stringifier.h ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698