Don't explicitly pass requested representations to constants; implement ConstantS

src/ia32/lithium-codegen-ia32.cc

Index: src/ia32/lithium-codegen-ia32.cc
diff --git a/src/ia32/lithium-codegen-ia32.cc b/src/ia32/lithium-codegen-ia32.cc
index 46dcec0d8804b66d808c024b75825cb18b23c637..4956d41924bd6d913bb70317da9beb81df59ebc6 100644
--- a/src/ia32/lithium-codegen-ia32.cc
+++ b/src/ia32/lithium-codegen-ia32.cc
@@ -1756,6 +1756,12 @@ void LCodeGen::DoConstantI(LConstantI* instr) {
 }
 
 
+void LCodeGen::DoConstantS(LConstantS* instr) {
+  ASSERT(instr->result()->IsRegister());

[Jakob Kummerow, 2013/05/29 10:12:53]

We don't need this ASSERT; ToRegister(foo) does an ASSERT(foo->IsRegister())
anyway. Feel free to remove it from DoConstantI as well.

+  __ Set(ToRegister(instr->result()), Immediate(instr->value()));
+}
+
+
 void LCodeGen::DoConstantD(LConstantD* instr) {
   double v = instr->value();
   uint64_t int_val = BitCast<uint64_t, double>(v);