Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 15929009: Use -O2 instead -O3 for Android build. (Closed)

Created:
7 years, 6 months ago by ulan
Modified:
7 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Use -O2 instead -O3 for Android build. It produces smaller binary with almost the same performance. R=benm@chromium.org, jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15071

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix error. #

Patch Set 3 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M build/android.gypi View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M build/common.gypi View 1 2 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ulan
Please take a look. Ben measured that this saves ~250K of binary size. Our perf ...
7 years, 6 months ago (2013-06-05 09:23:24 UTC) #1
Jakob Kummerow
lgtm https://chromiumcodereview.appspot.com/15929009/diff/1/build/android.gypi File build/android.gypi (right): https://chromiumcodereview.appspot.com/15929009/diff/1/build/android.gypi#newcode79 build/android.gypi:79: '-O3', Actually, I think you can delete everything ...
7 years, 6 months ago (2013-06-05 09:25:21 UTC) #2
ulan
https://chromiumcodereview.appspot.com/15929009/diff/1/build/android.gypi File build/android.gypi (right): https://chromiumcodereview.appspot.com/15929009/diff/1/build/android.gypi#newcode79 build/android.gypi:79: '-O3', On 2013/06/05 09:25:21, Jakob wrote: > Actually, I ...
7 years, 6 months ago (2013-06-05 09:30:59 UTC) #3
benm (inactive)
lgtm thanks Ulan!
7 years, 6 months ago (2013-06-05 09:36:50 UTC) #4
benm (inactive)
On 2013/06/05 09:36:50, benm wrote: > lgtm > > thanks Ulan! ping?
7 years, 6 months ago (2013-06-10 17:55:34 UTC) #5
ulan
I am going to land and roll it to chromium as a single-point release, so ...
7 years, 6 months ago (2013-06-11 08:09:01 UTC) #6
ulan
7 years, 6 months ago (2013-06-12 08:05:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r15071 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698