Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: build/common.gypi

Issue 15929009: Use -O2 instead -O3 for Android build. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address comment Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « build/android.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2012 the V8 project authors. All rights reserved. 1 # Copyright 2012 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 433 matching lines...) Expand 10 before | Expand all | Expand 10 after
444 ], 444 ],
445 }, # Debug 445 }, # Debug
446 'Release': { 446 'Release': {
447 'variables': { 447 'variables': {
448 'v8_enable_extra_checks%': 0, 448 'v8_enable_extra_checks%': 0,
449 }, 449 },
450 'conditions': [ 450 'conditions': [
451 ['v8_enable_extra_checks==1', { 451 ['v8_enable_extra_checks==1', {
452 'defines': ['ENABLE_EXTRA_CHECKS',], 452 'defines': ['ENABLE_EXTRA_CHECKS',],
453 }], 453 }],
454 ['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="netbsd" \ 454 ['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="netbsd"', {
455 or OS=="android"', {
456 'cflags!': [ 455 'cflags!': [
457 '-O2', 456 '-O2',
458 '-Os', 457 '-Os',
459 ], 458 ],
460 'cflags': [ 459 'cflags': [
461 '-fdata-sections', 460 '-fdata-sections',
462 '-ffunction-sections', 461 '-ffunction-sections',
463 '-O3', 462 '-O3',
464 ], 463 ],
465 'conditions': [ 464 'conditions': [
466 [ 'gcc_version==44 and clang==0', { 465 [ 'gcc_version==44 and clang==0', {
467 'cflags': [ 466 'cflags': [
468 # Avoid crashes with gcc 4.4 in the v8 test suite. 467 # Avoid crashes with gcc 4.4 in the v8 test suite.
469 '-fno-tree-vrp', 468 '-fno-tree-vrp',
470 ], 469 ],
471 }], 470 }],
472 ], 471 ],
473 }], 472 }],
473 ['OS=="android"', {
474 'cflags!': [
475 '-O3',
476 '-Os',
477 ],
478 'cflags': [
479 '-fdata-sections',
480 '-ffunction-sections',
481 '-O2',
482 ],
483 'conditions': [
484 [ 'gcc_version==44 and clang==0', {
485 'cflags': [
486 # Avoid crashes with gcc 4.4 in the v8 test suite.
487 '-fno-tree-vrp',
488 ],
489 }],
490 ],
491 }],
474 ['OS=="mac"', { 492 ['OS=="mac"', {
475 'xcode_settings': { 493 'xcode_settings': {
476 'GCC_OPTIMIZATION_LEVEL': '3', # -O3 494 'GCC_OPTIMIZATION_LEVEL': '3', # -O3
477 495
478 # -fstrict-aliasing. Mainline gcc 496 # -fstrict-aliasing. Mainline gcc
479 # enables this at -O2 and above, 497 # enables this at -O2 and above,
480 # but Apple gcc does not unless it 498 # but Apple gcc does not unless it
481 # is specified explicitly. 499 # is specified explicitly.
482 'GCC_STRICT_ALIASING': 'YES', 500 'GCC_STRICT_ALIASING': 'YES',
483 }, 501 },
(...skipping 23 matching lines...) Expand all
507 'OptimizeReferences': '2', 525 'OptimizeReferences': '2',
508 'EnableCOMDATFolding': '2', 526 'EnableCOMDATFolding': '2',
509 }, 527 },
510 }, 528 },
511 }], # OS=="win" 529 }], # OS=="win"
512 ], # conditions 530 ], # conditions
513 }, # Release 531 }, # Release
514 }, # configurations 532 }, # configurations
515 }, # target_defaults 533 }, # target_defaults
516 } 534 }
OLDNEW
« no previous file with comments | « build/android.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698