Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: gpu/command_buffer/service/gl_context_virtual.cc

Issue 15925007: Virtual context MakeCurrent tweaks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: keep explicit surface ref release Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/gpu/image_transport_surface_mac.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/gl_context_virtual.cc
diff --git a/gpu/command_buffer/service/gl_context_virtual.cc b/gpu/command_buffer/service/gl_context_virtual.cc
index dd32495c265978f1255659104be75612781e208c..e7a4c043bf7021fdacb0f8fb1a142173eb96f276 100644
--- a/gpu/command_buffer/service/gl_context_virtual.cc
+++ b/gpu/command_buffer/service/gl_context_virtual.cc
@@ -54,14 +54,11 @@ void GLContextVirtual::Destroy() {
}
bool GLContextVirtual::MakeCurrent(gfx::GLSurface* surface) {
- // TODO(epenner): We should avoid bypassing MakeVirtuallyCurrent() below
- // (return false or DCHECK when !decoder). To do this we must reorder
- // tear-down in GpuCommandBufferStub::Destroy().
if (decoder_.get())
- shared_context_->MakeVirtuallyCurrent(this, surface);
- else if (!IsCurrent(surface))
- shared_context_->MakeCurrent(surface);
- return true;
+ return shared_context_->MakeVirtuallyCurrent(this, surface);
+
+ LOG(ERROR) << "Trying to make virtual context current without decoder.";
+ return false;
}
void GLContextVirtual::ReleaseCurrent(gfx::GLSurface* surface) {
« no previous file with comments | « content/common/gpu/image_transport_surface_mac.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698