Refactor ActivityStatus to not store current activity

base/android/application_state_list.h

Index: base/android/application_state_list.h
diff --git a/base/android/application_state_list.h b/base/android/application_state_list.h
new file mode 100644
index 0000000000000000000000000000000000000000..d670c275dc06748ef8e80019871fcb8db49cc07d
--- /dev/null
+++ b/base/android/application_state_list.h
@@ -0,0 +1,14 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// This file intentionally does not have header guards, it's included
+// inside a macro to generate enum values.
+
+#ifndef DEFINE_APPLICATION_STATE
+#error "DEFINE_APPLICATION_STATE should be defined before including this file"
+#endif
+DEFINE_APPLICATION_STATE(HAS_RUNNING_ACTIVITIES, 1)
+DEFINE_APPLICATION_STATE(HAS_ONLY_PAUSED_ACTIVITIES, 2)

[Ted C, 2014/02/18 18:18:29]

I would drop the _ONLY_ as that is not usually correct.  It's actually the most
visible activity state, so I would just leave it as (or maybe even drop the
HAS_):

HAS_RESUMED_ACTIVITIES
HAS_PAUSED_ACTIVITES
HAS_STOPPED_ACTIVITIES
HAS_DESTROYED_ACTIVITIES

Sadly, I think this will only be clear if you read the documentation.  I don't
think we want enum names:

MOST_VISIBLE_ACTIVITY_IS_RUNNING
MOST_VISIBLE_ACTIVITY_IS_PAUSED
MOST_VISIBLE_ACTIVITY_IS_STOPPED
MOST_VISIBLE_ACTIVITY_IS_DESTROYED

[David Trainor- moved to gerrit, 2014/02/18 19:54:15]

Done.

+DEFINE_APPLICATION_STATE(HAS_ONLY_STOPPED_ACTIVITIES, 3)
+DEFINE_APPLICATION_STATE(HAS_ONLY_DESTROYED_ACTIVITIES, 3)

[bulach, 2014/02/17 12:04:01]

is it intentional to have the same value as above?

[David Trainor- moved to gerrit, 2014/02/18 19:54:15]

Done.