base/android/application_state_list.h - Issue 159173002: Refactor ActivityStatus to not store current activity

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/android/application_state_list.h

Issue 159173002: Refactor ActivityStatus to not store current activity (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Forgot to set callback_, fixed unit tests Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // This file intentionally does not have header guards, it's included

	6 // inside a macro to generate enum values.

	7

	8 #ifndef DEFINE_APPLICATION_STATE

	9 #error "DEFINE_APPLICATION_STATE should be defined before including this file"

	10 #endif

	11 DEFINE_APPLICATION_STATE(HAS_RUNNING_ACTIVITIES, 1)

	12 DEFINE_APPLICATION_STATE(HAS_ONLY_PAUSED_ACTIVITIES, 2)
	Ted C 2014/02/18 18:18:29 I would drop the _ONLY_ as that is not usually cor I would drop the _ONLY_ as that is not usually correct. It's actually the most visible activity state, so I would just leave it as (or maybe even drop the HAS_): HAS_RESUMED_ACTIVITIES HAS_PAUSED_ACTIVITES HAS_STOPPED_ACTIVITIES HAS_DESTROYED_ACTIVITIES Sadly, I think this will only be clear if you read the documentation. I don't think we want enum names: MOST_VISIBLE_ACTIVITY_IS_RUNNING MOST_VISIBLE_ACTIVITY_IS_PAUSED MOST_VISIBLE_ACTIVITY_IS_STOPPED MOST_VISIBLE_ACTIVITY_IS_DESTROYED David Trainor- moved to gerrit 2014/02/18 19:54:15 Done. Show quoted text On 2014/02/18 18:18:29, Ted C wrote: > I would drop the _ONLY_ as that is not usually correct. It's actually the most > visible activity state, so I would just leave it as (or maybe even drop the > HAS_): > > HAS_RESUMED_ACTIVITIES > HAS_PAUSED_ACTIVITES > HAS_STOPPED_ACTIVITIES > HAS_DESTROYED_ACTIVITIES > > Sadly, I think this will only be clear if you read the documentation. I don't > think we want enum names: > > MOST_VISIBLE_ACTIVITY_IS_RUNNING > MOST_VISIBLE_ACTIVITY_IS_PAUSED > MOST_VISIBLE_ACTIVITY_IS_STOPPED > MOST_VISIBLE_ACTIVITY_IS_DESTROYED Done.
	13 DEFINE_APPLICATION_STATE(HAS_ONLY_STOPPED_ACTIVITIES, 3)

	14 DEFINE_APPLICATION_STATE(HAS_ONLY_DESTROYED_ACTIVITIES, 3)
	bulach 2014/02/17 12:04:01 is it intentional to have the same value as above? is it intentional to have the same value as above? David Trainor- moved to gerrit 2014/02/18 19:54:15 Done. Show quoted text On 2014/02/17 12:04:01, bulach wrote: > is it intentional to have the same value as above? Done.
OLD	NEW

« no previous file with comments | « base/android/activity_status_unittest.cc ('k') | base/android/application_status_listener.h » ('j') | base/android/base_jni_registrar.cc » ('J')