Refactor ActivityStatus to not store current activity

ui/base/android/window_android.h

Index: ui/base/android/window_android.h
diff --git a/ui/base/android/window_android.h b/ui/base/android/window_android.h
index 5e6532eac8060b25b5e02a21a9b29115abf2b5aa..d9386981795608672bdfbaf9da24cc0e80747f44 100644
--- a/ui/base/android/window_android.h
+++ b/ui/base/android/window_android.h
@@ -24,7 +24,7 @@ class UI_BASE_EXPORT WindowAndroid {
 
   void Destroy(JNIEnv* env, jobject obj);
 
-  base::android::ScopedJavaLocalRef<jobject> GetJavaObject();
+  base::android::ScopedJavaLocalRef<jobject> GetJavaObject() const;

[Ted C, 2014/02/13 04:38:44]

Hmm...why is this const?

Allowing const to access java seems like a really easy way to avoid const guards
(and not to mention java has no concept of const so you can get the java object
and call any sort of mutators you'd like).

[David Trainor- moved to gerrit, 2014/02/13 05:03:55]

Dogh!  I passed a const WindowAndroid* through in
ssl_client_certificate_request.  I'll remove const there and remove it from
here.  That does makes more sense.  I don't know why I added const there to
begin with :/.

Although semantically I think this is fine as long as the method doesn't change
anything in WindowAndroid (which the get method does not).  If we wanted to
protect the returned object wouldn't we just prepend const to the return
parameter?  A const getter doesn't have to return an immutable object.  Although
like you said since Java could in theory be used to mutate this object and
they're supposedly representing the same thing you have a good point.

[David Trainor- moved to gerrit, 2014/02/14 19:13:36]

Done.

 
   static bool RegisterWindowAndroid(JNIEnv* env);