Refactor ActivityStatus to not store current activity

ui/base/android/window_android.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_BASE_ANDROID_WINDOW_ANDROID_H_
 #define UI_BASE_ANDROID_WINDOW_ANDROID_H_
 
 #include <jni.h>
 #include <vector>
 #include "base/android/jni_helper.h"
 #include "base/android/scoped_java_ref.h"
 #include "base/observer_list.h"
 #include "ui/base/ui_base_export.h"
 #include "ui/gfx/vector2d_f.h"
 
 namespace ui {
 
 class WindowAndroidObserver;
 
 // Android implementation of the activity window.
 class UI_BASE_EXPORT WindowAndroid {
  public:
   WindowAndroid(JNIEnv* env, jobject obj);
 
   void Destroy(JNIEnv* env, jobject obj);
 
-  base::android::ScopedJavaLocalRef<jobject> GetJavaObject();
+  base::android::ScopedJavaLocalRef<jobject> GetJavaObject() const;

[Ted C, 2014/02/13 04:38:44]

Hmm...why is this const?

Allowing const to access java seems like a really easy way to avoid const guards
(and not to mention java has no concept of const so you can get the java object
and call any sort of mutators you'd like).

[David Trainor- moved to gerrit, 2014/02/13 05:03:55]

Dogh!  I passed a const WindowAndroid* through in
ssl_client_certificate_request.  I'll remove const there and remove it from
here.  That does makes more sense.  I don't know why I added const there to
begin with :/.

Although semantically I think this is fine as long as the method doesn't change
anything in WindowAndroid (which the get method does not).  If we wanted to
protect the returned object wouldn't we just prepend const to the return
parameter?  A const getter doesn't have to return an immutable object.  Although
like you said since Java could in theory be used to mutate this object and
they're supposedly representing the same thing you have a good point.

[David Trainor- moved to gerrit, 2014/02/14 19:13:36]

Done.

 
   static bool RegisterWindowAndroid(JNIEnv* env);
 
   // The content offset is used to translate snapshots to the correct part of
   // the window.
   void set_content_offset(const gfx::Vector2dF& content_offset) {
     content_offset_ = content_offset;
   }
 
   bool GrabSnapshot(int content_x, int content_y, int width, int height,
@@ skipping 15 matching lines @@
   gfx::Vector2dF content_offset_;
 
   ObserverList<WindowAndroidObserver> observer_list_;
 
   DISALLOW_COPY_AND_ASSIGN(WindowAndroid);
 };
 
 }  // namespace ui
 
 #endif  // UI_BASE_ANDROID_WINDOW_ANDROID_H_