Issue 15917016: [Telemetry] Don't restart the browser when the WPR archive path changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15917016: [Telemetry] Don't restart the browser when the WPR archive path changes. (Closed)

Created:
7 years, 6 months ago by tonyg

Modified:
7 years, 6 months ago

Reviewers:
dtu, marja

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Telemetry] Don't restart the browser when the WPR archive path changes. Simply restart WPR using the same port it was on before. The browser will still be set up to point to that port. I think we originally restarted the browser because we used to not explicitly pass the ports to use to WPR. Now that those are stored in browser_backend, they can stay stable across WPR restarts. BUG=None TEST=tools/perf/run_measurement --browser=android-content-shell page_cycler tools/perf/page_sets/top_25.json --page-filter="youtube|plus" --pageset-repeat=1 -v NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202877

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	tools/telemetry/telemetry/page/page_runner.py	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/15917016/1

7 years, 6 months ago (2013-05-29 15:34:41 UTC) #4

Message was sent while issue was closed.

Change committed as 202877

Expand Messages | Collapse Messages