tools/telemetry/telemetry/page/page_runner.py - Issue 15917016: [Telemetry] Don't restart the browser when the WPR archive path changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 15917016: [Telemetry] Don't restart the browser when the WPR archive path changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/page_runner.py

diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py

index edf7be8a09425455f7d82125971360628ad5399c..2cad4a32a01bff66fa1b0c1fb1a35f9a7b485b4d 100644

--- a/tools/telemetry/telemetry/page/page_runner.py

+++ b/tools/telemetry/telemetry/page/page_runner.py

@@ -105,9 +105,8 @@ class PageRunner(object):

possible_browser.options.wpr_mode = wpr_modes.WPR_REPLAY

else:

possible_browser.options.wpr_mode = wpr_modes.WPR_OFF

- if last_archive_path != page.archive_path:

- state.Close()

- state = _RunState()

+ if last_archive_path != page.archive_path and state.browser:

+ state.browser.SetReplayArchivePath(page.archive_path)

last_archive_path = page.archive_path

if (test.discard_first_result and

not self.has_called_will_run_page_set):

« no previous file with comments | « no previous file | no next file » | no next file with comments »