Change Certificate Viewer WebUI to match new style.

Change Certificate Viewer WebUI to match new style.

Changes the internals of the certificate viewer dialog so it matches the
specs for the new dialog style. Screenshots in bug, specs are here: https://drive.google.com/a/google.com/folderview?id=0B6x6iYCtKinEUTFOWUJFTWJFSTA&usp=sharing#list

BUG=140561, 247772
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205480

[Evan Stade, 2013-06-04 17:56:28]

https://codereview.chromium.org/15894032/diff/2001/chrome/browser/resources/c...
File chrome/browser/resources/certificate_viewer.css (right):

https://codereview.chromium.org/15894032/diff/2001/chrome/browser/resources/c...
chrome/browser/resources/certificate_viewer.css:34: #tabs {
this doesn't seem right. You should do all this in tabs.css. If you don't want
to change all existing uses of tabs, you can do something like

tabs.new-style-tabs {
  ...
}

but I'd still put that in tabs.css.

[Rune Fevang, 2013-06-04 22:43:00]

https://codereview.chromium.org/15894032/diff/2001/chrome/browser/resources/c...
File chrome/browser/resources/certificate_viewer.css (right):

https://codereview.chromium.org/15894032/diff/2001/chrome/browser/resources/c...
chrome/browser/resources/certificate_viewer.css:34: #tabs {
On 2013/06/04 17:56:28, Evan Stade wrote:
> this doesn't seem right. You should do all this in tabs.css. If you don't want
> to change all existing uses of tabs, you can do something like
> 
> tabs.new-style-tabs {
>   ...
> }
> 
> but I'd still put that in tabs.css.

Good idea! I didn't change tabs.css because I didn't want change the non-bubble
tab styles. I considered creating a new file and linking to that instead of
tabs.css, but didn't since this is the only place that I knew of that would use
it. I like your idea better though, done :)

[Evan Stade, 2013-06-04 23:46:59]

https://codereview.chromium.org/15894032/diff/13001/ui/webui/resources/css/ta...
File ui/webui/resources/css/tabs.css (right):

https://codereview.chromium.org/15894032/diff/13001/ui/webui/resources/css/ta...
ui/webui/resources/css/tabs.css:18: tabs.new-style-tabs {
add docs about .new-style-tabs: do we want to move all tabs to this style? If
not, .new-style-tabs might not be the best class name

[Rune Fevang, 2013-06-07 19:43:10]

https://codereview.chromium.org/15894032/diff/13001/ui/webui/resources/css/ta...
File ui/webui/resources/css/tabs.css (right):

https://codereview.chromium.org/15894032/diff/13001/ui/webui/resources/css/ta...
ui/webui/resources/css/tabs.css:18: tabs.new-style-tabs {
On 2013/06/04 23:46:59, Evan Stade wrote:
> add docs about .new-style-tabs: do we want to move all tabs to this style? If
> not, .new-style-tabs might not be the best class name

I talked to one of the UX people, and he said the other uses should move to this
style too.

Where would I add documentation? Are there any examples?

[Evan Stade, 2013-06-07 19:52:11]

On 2013/06/07 19:43:10, Rune Fevang wrote:
>
https://codereview.chromium.org/15894032/diff/13001/ui/webui/resources/css/ta...
> File ui/webui/resources/css/tabs.css (right):
> 
>
https://codereview.chromium.org/15894032/diff/13001/ui/webui/resources/css/ta...
> ui/webui/resources/css/tabs.css:18: tabs.new-style-tabs {
> On 2013/06/04 23:46:59, Evan Stade wrote:
> > add docs about .new-style-tabs: do we want to move all tabs to this style?
If
> > not, .new-style-tabs might not be the best class name
> 
> I talked to one of the UX people, and he said the other uses should move to
this
> style too.
> 
> Where would I add documentation? Are there any examples?

just in the file, above the rule. Filing a bug would be good as well.

[Rune Fevang, 2013-06-07 21:23:39]

https://codereview.chromium.org/15894032/diff/13001/ui/webui/resources/css/ta...
File ui/webui/resources/css/tabs.css (right):

https://codereview.chromium.org/15894032/diff/13001/ui/webui/resources/css/ta...
ui/webui/resources/css/tabs.css:18: tabs.new-style-tabs {
On 2013/06/04 23:46:59, Evan Stade wrote:
> add docs about .new-style-tabs: do we want to move all tabs to this style? If
> not, .new-style-tabs might not be the best class name

Done.

[Evan Stade, 2013-06-10 18:46:46]

thanks, lgtm. You can add the new bug to the BUG= list.

[commit-bot: I haz the power, 2013-06-10 19:07:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rfevang@chromium.org/15894032/19001

[commit-bot: I haz the power, 2013-06-10 22:31:54]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-06-10 23:34:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rfevang@chromium.org/15894032/19001

[commit-bot: I haz the power, 2013-06-11 10:24:56]

Change committed as 205480